Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127362
Precedence: bulk
MIME-Version: 1.0
Date: Wed, 14 May 2025 23:00:01 +0200
To: Matthew Weier O'Phinney <mweierophinney@gmail.com>
Cc: Volker Dusch <volker@tideways-gmbh.com>, php internals
 <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] Clone with v2
In-Reply-To: <CAJp_myXREmnyufwxj4tDCsopouUFEWenap5EJaH+sXKTyg4K1Q@mail.gmail.com>
References: <CAMzRQTdePFXUMWO38g=gQA2vbqL5zp=o1cPt00ec41g95xys=g@mail.gmail.com>
 <CAJp_myXREmnyufwxj4tDCsopouUFEWenap5EJaH+sXKTyg4K1Q@mail.gmail.com>
Message-ID: <4a703db4174763586d84b9bf5606ff31@bastelstu.be>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

Am 2025-05-14 22:06, schrieb Matthew Weier O'Phinney:
> The only question that arose for me is: what happens if a property name 
> is
> provided to `clone()` that does not exist in the class definition; what
> will be the behavior at that time? Will an exception or error be 
> thrown? If
> so, will it be a new one, or an existing one?

It's mentioned in the "Technical details" section:

> Property assignments are made just as a regular assignment would be

It literally goes through the same code path. Thus a dynamic property 
will be created (and the associated warnings triggered). You can also 
see that in test `Zend/tests/clone/clone_with_002.phpt` of the 
implementation:

> Deprecated: Creation of dynamic property C::$c is deprecated in %s on 
> line %d

The internal implementation is roughly equivalent to:

     $cloned = clone $object;
     foreach ($withProperties as $key => $value) {
         $cloned->{$key} = $value;
     }
     return $cloned;

Just with the exception that writing readonly properties is allowed on 
the clone (unless already touched by `__clone()`).

Best regards
Tim Düsterhus