Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127332
Date: Sun, 11 May 2025 13:35:03 +0000
To: =?utf-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: internals@lists.php.net
Subject: Re: [PHP-DEV] Disallow dynamic calls to assert()?
Message-ID: <mOpLBV12QRMp6s5i7Og0uEPdtBiNlVPmtSNLLbk2ryc0Wp4Yc0I618X82nl9-3DzMleyF1RtQqSaHmjWjkhOhNa4ODWB1ku0XFQDOUOnYOw=@gpb.moe>
In-Reply-To: <7d47ba135b9ff6f88caa23cc5638dc5d@bastelstu.be>
References: <7d47ba135b9ff6f88caa23cc5638dc5d@bastelstu.be>
Feedback-ID: 96993444:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: internals@gpb.moe ("Gina P. Banyard")

On Friday, 9 May 2025 at 08:35, Tim D=C3=BCsterhus <tim@bastelstu.be> wrote=
:

> Hi
>=20
> I noticed that dynamic calls to the `assert()` function do not take the
> `zend.assertions` into account, since for static calls `zend.assertions`
> is checked inside the compiler to completely bypass the call to
> `assert()` including the evaluation of all arguments. I created a PR to
> fix that, making dynamic calls to assert always return true just like
> static calls:
>=20
> https://github.com/php/php-src/pull/18521
>=20
> However these dynamic calls still evaluate their arguments, which makes
> for a behavioral difference that might be confusing. Niels rightfully
> pointed out that it is possible to forbid dynamic calls to a given
> function, this is already used for things like `compact()` or
> `func_get_args()`. Disallowing dynamic calls to `assert()` would
> completely bypass this problem.
>=20
> Does anyone have an opinion either way? Please comment on the GitHub
> issue if you do so:
> https://github.com/php/php-src/pull/18521#pullrequestreview-2825782965
>=20
> Best regards
> Tim D=C3=BCsterhus

This makes sense to me, I don't really see why one would ever need to call =
assert dynamically.
Is it possible to prevent retrieving a closure by using the FCC syntax at c=
ompile time?

Best regards,

Gina P. Banyard