Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127276
Precedence: bulk
MIME-Version: 1.0
References: <CAH5C8xUb1O20ZDrOQNC=ckFxHUUWSK7sw_njQQzFBd0qgQqoww@mail.gmail.com>
 <dd61999c-1ebd-4765-9add-cd8065968965@gmail.com> <CAOV5rgYZ_s1of-igLFEK7oqqh6=3HeYv0=JvvKvvjkcp0F6Q9Q@mail.gmail.com>
 <CAH5C8xV67frqOBCvLt73RM7QO86_pu40sHP5h71_kDRbKPtA8Q@mail.gmail.com>
 <1BCB4144-231D-45EA-A914-98EE8F0F503A@automattic.com> <8E614C9C-BA85-45D8-9A4E-A30D69981C5D@automattic.com>
 <CAH5C8xV69pHnSKWJrVB8EQab7vPhcaXAwYezoG6z3Oj7ZkXBaQ@mail.gmail.com>
 <bc5472e39bc607e2c7accc9d2bd6f239@bastelstu.be> <CAH5C8xW_auVf+ig7odhTK8dVWwmXTg4ZVZN-0Fhh4SUBzrWxVw@mail.gmail.com>
 <8df04e01-deac-404b-beb7-cd982423db63@bastelstu.be> <CAH5C8xU0JcnmC2Hdd=Hj0CQUaL0-LN=1X8+5-eUbFH3ZMxCvBA@mail.gmail.com>
 <33427cd03035ef084245c44290b56a55@bastelstu.be> <CAH5C8xXwDO6Ui8pLmqoxEguURh97fAaL4CfLK-oitqC85N7+8w@mail.gmail.com>
 <0aa1eefc3941bdea0092e935074daa58@bastelstu.be> <CAH5C8xU+rnp4e5=CzqhEncRww6nhZ7x1s68NjWtu+HQMpoNZ8g@mail.gmail.com>
 <76d96ea8a78c6025128c0a4b01c94c0a@bastelstu.be> <CAOV5rgbYk7xZShs1933JR29NKr_MSCRqvkTdzn0Wpt4ejAC8TQ@mail.gmail.com>
In-Reply-To: <CAOV5rgbYk7xZShs1933JR29NKr_MSCRqvkTdzn0Wpt4ejAC8TQ@mail.gmail.com>
Date: Sat, 3 May 2025 23:18:35 +0200
Message-ID: <CAH5C8xWYcwy0DyqT12bGOSPdvhH_0DiRxJKO-=xaCbC9a71wjQ@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add WHATWG compliant URL parsing API
To: ignace nyamagana butera <nyamsprod@gmail.com>
Cc: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>, 
	PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ede321063441cfbf"
From: kocsismate90@gmail.com (=?UTF-8?B?TcOhdMOpIEtvY3Npcw==?=)

--000000000000ede321063441cfbf
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hey Ignace,


> I see you updated the RFC but I believe there's still some errors in the
> example:
> $url =3D Uri\WhatWg\Url::parse("/foo", ".com"); // Throws
> Uri\WhatWg\InvalidUrlException because of $baseUri
>

After following the suggestion of Tim, I changed the type of the $baseUrl
parameters at last: now, an URI/URL instance is
accepted instead of a string. As Tim mentioned, this can indeed fix some
performance issues when one uses the same
base URL for instantiating multiple URIs/URLs.

RFC3986 host normalization states that URL encoded part should be encoded
> using uppercased letter so on normalization:
>
https://%e4%bd%a0%e5%a5%bd%e4%bd%a0%e5%a5%bd.com should be https://
> %E4%BD%A0%E5%A5%BD%E4%BD%A0%E5%A5%BD.com
>

Yes, indeed! This example output has stuck here from before I fixed the
implementation, so thanks for pointing it out!

Regards,
M=C3=A1t=C3=A9

>

--000000000000ede321063441cfbf
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr">Hey Ignace,</div><div cl=
ass=3D"gmail_quote"><div>=C2=A0</div><blockquote class=3D"gmail_quote" styl=
e=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddin=
g-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><div>I see you updated the RF=
C but I believe there&#39;s still some errors in the example:</div>$url =3D=
 Uri\WhatWg\Url::parse(&quot;/foo&quot;, &quot;.com&quot;); // Throws Uri\W=
hatWg\InvalidUrlException because of $baseUri</div></div></blockquote><div>=
=C2=A0</div><div>After following the suggestion of Tim, I changed the type =
of the $baseUrl parameters at=C2=A0last: now, an URI/URL instance is</div><=
div>accepted instead of a string. As Tim mentioned, this can indeed fix som=
e performance issues when one uses the same</div><div>base URL for instanti=
ating multiple URIs/URLs.</div><div><br></div><blockquote class=3D"gmail_qu=
ote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,20=
4);padding-left:1ex"><div dir=3D"ltr">RFC3986 host normalization states tha=
t URL encoded part should be encoded using uppercased letter so on normaliz=
ation:</div></blockquote><blockquote class=3D"gmail_quote" style=3D"margin:=
0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">=
<div dir=3D"ltr">https://%e4%bd%a0%e5%a5%bd%e4%bd%a0%e5%a5%<a href=3D"http:=
//bd.com">bd.com</a> should be https://%E4%BD%A0%E5%A5%BD%E4%BD%A0%E5%A5%BD=
.com</div></blockquote><div>=C2=A0</div><div>Yes, indeed! This example outp=
ut has stuck here from before I fixed the implementation, so thanks for poi=
nting it out!</div><div><br></div><div>Regards,</div><div>M=C3=A1t=C3=A9</d=
iv><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bord=
er-left:1px solid rgb(204,204,204);padding-left:1ex">
</blockquote></div></div>
</div>

--000000000000ede321063441cfbf--