Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127257
Feedback-ID: i8414410d:Fastmail
Precedence: bulk
MIME-Version: 1.0
Date: Wed, 30 Apr 2025 15:12:55 -0500
To: "php internals" <internals@lists.php.net>
Message-ID: <36830fef-1594-4b19-8833-62aeb6a36389@app.fastmail.com>
In-Reply-To: <ec04f7b5-2a94-4420-b523-6956cd543dcd@bastelstu.be>
References: <ffadb6e6-5d16-4b45-a020-4b91565e2ee6@bastelstu.be>
 <4233b00a-7593-e70d-f235-da650cd7bac6@php.net>
 <c3e2ab01-86a4-40ee-ad7f-467a58a6b0bc@app.fastmail.com>
 <ec04f7b5-2a94-4420-b523-6956cd543dcd@bastelstu.be>
Subject: Re: [PHP-DEV] [RFC] Throwable Hierarchy Policy for Extensions
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: larry@garfieldtech.com ("Larry Garfield")

On Wed, Apr 30, 2025, at 1:06 PM, Tim D=C3=BCsterhus wrote:
> Hi
>
> On 4/30/25 15:33, Larry Garfield wrote:
>> The only time I've seen anyone use $code is in TYPO3.  Their coding s=
tandards say that any time you throw an exception, you use the current t=
imestamp (determined manually) as a code.  That way there is a globally =
unique code regardless of exception type that can be grepped to find the=
 exact line it came from.
>
> To my understanding this would result in effectively identical=20
> exceptions having different codes, just because checking the error=20
> condition is split across different `if()` statements for readability?=20
> That doesn't seem like a good idea - and that's why the RFC uses =E2=80=
=9Ccause=E2=80=9D=20
> as the wording of choice.

Correct.  There's 400 `throw new InvalidArgumentException('...', 1234567=
98)` calls across the code base, each with a unique code number timestam=
p.

I didn't care for this approach either when I worked at TYPO3. :-)  My p=
oint being that I've rarely if ever seen $code used in a constructive an=
d useful fashion.

>> [=E2=80=A6] just that it's the only time I've seen $code used in the =
wild...
>>=20
>
> PDO (for better or worse) also uses the `$code` for the error code=20
> returned by the database. Unfortunately it also widens the (untyped)=20
> $code from int to string|int, which causes some issues, since folks on=
ly=20
> expect int, since Exception::__construct() types the `$code` parameter=20
> as `int`.
>
> Best regards
> Tim D=C3=BCsterhus

In my experience, worse.  But that's another topic.

--Larry Garfield