Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127255
Message-ID: <ec04f7b5-2a94-4420-b523-6956cd543dcd@bastelstu.be>
Date: Wed, 30 Apr 2025 20:06:36 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [RFC] Throwable Hierarchy Policy for Extensions
To: Larry Garfield <larry@garfieldtech.com>,
 php internals <internals@lists.php.net>
References: <ffadb6e6-5d16-4b45-a020-4b91565e2ee6@bastelstu.be>
 <4233b00a-7593-e70d-f235-da650cd7bac6@php.net>
 <c3e2ab01-86a4-40ee-ad7f-467a58a6b0bc@app.fastmail.com>
Content-Language: en-US
In-Reply-To: <c3e2ab01-86a4-40ee-ad7f-467a58a6b0bc@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 4/30/25 15:33, Larry Garfield wrote:
> The only time I've seen anyone use $code is in TYPO3.  Their coding standards say that any time you throw an exception, you use the current timestamp (determined manually) as a code.  That way there is a globally unique code regardless of exception type that can be grepped to find the exact line it came from.

To my understanding this would result in effectively identical 
exceptions having different codes, just because checking the error 
condition is split across different `if()` statements for readability? 
That doesn't seem like a good idea - and that's why the RFC uses “cause” 
as the wording of choice.

> […] just that it's the only time I've seen $code used in the wild...
> 

PDO (for better or worse) also uses the `$code` for the error code 
returned by the database. Unfortunately it also widens the (untyped) 
$code from int to string|int, which causes some issues, since folks only 
expect int, since Exception::__construct() types the `$code` parameter 
as `int`.

Best regards
Tim Düsterhus