Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127251
Date: Wed, 30 Apr 2025 12:18:26 +0100 (BST)
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
cc: PHP internals <internals@lists.php.net>, 
    "Gina P. Banyard" <internals@gpb.moe>
Subject: Re: [PHP-DEV] [RFC] Throwable Hierarchy Policy for Extensions
In-Reply-To: <ffadb6e6-5d16-4b45-a020-4b91565e2ee6@bastelstu.be>
Message-ID: <4233b00a-7593-e70d-f235-da650cd7bac6@php.net>
References: <ffadb6e6-5d16-4b45-a020-4b91565e2ee6@bastelstu.be>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1145515999-1746011665=:76401"
From: derick@php.net (Derick Rethans)

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1145515999-1746011665=:76401
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Sun, 27 Apr 2025, Tim D=C3=BCsterhus wrote:

> Hi
>=20
> as announced in the URI RFC discussion thread
> (https://externals.io/message/123997#127142), I've now written up an
> =E2=80=9CException Hierarchy=E2=80=9D policy RFC together with Gina.
>=20
> Please find the following links:
>=20
> RFC: https://wiki.php.net/rfc/extension_exceptions
> Policy PR: https://github.com/php/policies/pull/17
>=20
> The RFC itself also contains additional references.
>=20
> This message is intended to begin the official discussion period. Please =
do
> not comment on the PR itself, but reply to this discussion thread for pro=
per
> visibility.

- Exceptions MUST NOT be ``final``.

Could the RFC explain why not?

- The name of the extension SHOULD NOT be used as a prefix or suffix of=20
  the unqualified class name of additional exceptions.

Could you add an example of how to do it instead (or a "not this" "but=20
that" example)?

- Any two exceptions with different causes MUST be identifiable either=20
  by a unique exception class name, a stable ``$code``, or a=20
  class-specific additional property suitable for programmatic=20
  consumption (e.g. an enum).

I would probably not even allow the stable ``$code`` in here, as I have=20
seen from experience people don't really check for them.

cheers,
Derick


--=20
https://derickrethans.nl | https://xdebug.org | https://dram.io

Author of Xdebug. Like it? Consider supporting me: https://xdebug.org/suppo=
rt

mastodon: @derickr@phpc.social @xdebug@phpc.social
--8323329-1145515999-1746011665=:76401--