Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127237
Precedence: bulk
MIME-Version: 1.0
References: <CAH5C8xUb1O20ZDrOQNC=ckFxHUUWSK7sw_njQQzFBd0qgQqoww@mail.gmail.com>
 <CAOV5rgYZ_s1of-igLFEK7oqqh6=3HeYv0=JvvKvvjkcp0F6Q9Q@mail.gmail.com>
 <CAH5C8xV67frqOBCvLt73RM7QO86_pu40sHP5h71_kDRbKPtA8Q@mail.gmail.com>
 <1BCB4144-231D-45EA-A914-98EE8F0F503A@automattic.com> <8E614C9C-BA85-45D8-9A4E-A30D69981C5D@automattic.com>
 <CAH5C8xV69pHnSKWJrVB8EQab7vPhcaXAwYezoG6z3Oj7ZkXBaQ@mail.gmail.com>
 <bc5472e39bc607e2c7accc9d2bd6f239@bastelstu.be> <CAH5C8xW_auVf+ig7odhTK8dVWwmXTg4ZVZN-0Fhh4SUBzrWxVw@mail.gmail.com>
 <8df04e01-deac-404b-beb7-cd982423db63@bastelstu.be> <CAH5C8xU0JcnmC2Hdd=Hj0CQUaL0-LN=1X8+5-eUbFH3ZMxCvBA@mail.gmail.com>
 <33427cd03035ef084245c44290b56a55@bastelstu.be> <CAH5C8xXwDO6Ui8pLmqoxEguURh97fAaL4CfLK-oitqC85N7+8w@mail.gmail.com>
 <0aa1eefc3941bdea0092e935074daa58@bastelstu.be> <CAH5C8xU+rnp4e5=CzqhEncRww6nhZ7x1s68NjWtu+HQMpoNZ8g@mail.gmail.com>
 <76d96ea8a78c6025128c0a4b01c94c0a@bastelstu.be> <CAH5C8xXLPoRLJ6_dtotMtOv2NWs4LFzu+Kpr5A56Xk8wmuPDEg@mail.gmail.com>
 <07a8a580-4f0c-4b2f-8a67-b91dacfe99bf@bastelstu.be> <CAOV5rgZZgSjGWFdhWm7qwiRxeRMvf7ScgoPZZEXgnvK8Qyw38w@mail.gmail.com>
 <CAH5C8xWSaSXDoXJ-18WptA-dN6Tt6N-DUwLk6PxR1ERP_pwSLA@mail.gmail.com> <CAOV5rgYx-EeAN=TFa02pCG-7=KJTmLEf=WtXDTBUmUwnJPRcow@mail.gmail.com>
In-Reply-To: <CAOV5rgYx-EeAN=TFa02pCG-7=KJTmLEf=WtXDTBUmUwnJPRcow@mail.gmail.com>
Date: Tue, 29 Apr 2025 10:54:45 +0200
Message-ID: <CAOV5rgbcCd1pp05xmtEu9SgCjDqu1FXfJPwPfczqH1L_q=pS7w@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add WHATWG compliant URL parsing API
To: =?UTF-8?B?TcOhdMOpIEtvY3Npcw==?= <kocsismate90@gmail.com>, 
	PHP Internals List <internals@lists.php.net>, =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Content-Type: multipart/alternative; boundary="0000000000006bd8870633e6f429"
From: nyamsprod@gmail.com (ignace nyamagana butera)

--0000000000006bd8870633e6f429
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Mat=C3=A9 and Time,

I have one last question while reviewing my polyfill implementation. Is it
worth it adding a SensitiveParameter attribute on the argument of the
following methods ?

- Uri\Rfc3986\Uri::withUserInfo
- Uri\WhatWg\Url::withPassword

I'm fine with any answer ? Does it warrant a paragraph in the RFC ? That I
do not know but I feel the question may be raised ?

Best regards,
Ignace Nyamagana Butera

On Mon, Apr 28, 2025 at 11:31=E2=80=AFPM ignace nyamagana butera <
nyamsprod@gmail.com> wrote:

> Hi Mat=C3=A9,
>
> > I fiddled a little bit with the implementation, and I went with the
> Uri\UriComparisonMode enum name at last. I hope that it is OK on your sid=
e.
>
> If no one objects with your name choice I am fine with it, as long as it
> is not a boolean :)  I will adapt my polyfill. I think I have no more
> remarks from my side of things, great job! Since I do not have  the right
> to vote I hope this one will pass when time for voting comes!
>
> On Mon, Apr 28, 2025 at 11:21=E2=80=AFPM M=C3=A1t=C3=A9 Kocsis <kocsismat=
e90@gmail.com>
> wrote:
>
>> Hi Ignace,
>>
>> The $excludeFragment is `true` by default so in the example it should be
>>> `false` instead. Perhaps using an Enum instead would make the
>>> DX easier than using a boolean ?
>>> I believe the same issue is in all examples regarding the use of that
>>> parameter.
>>>
>>
>> You are right, I completely messed up the value of the $excludeFragment
>> variables in the examples. After having thought about your suggestion, I=
'm
>> fine with adding the enum.
>> It's a bit verbose indeed, but at least it properly conveys the meaning
>> of the parameter, so hopefully it will reduce the number of WTFs when
>> people start to use the new API. :)
>>
>> I fiddled a little bit with the implementation, and I went with the
>> Uri\UriComparisonMode enum name at last. I hope that it is OK on your si=
de.
>>
>> Regards,
>> M=C3=A1t=C3=A9
>>
>

--0000000000006bd8870633e6f429
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Mat=C3=A9 and Time,<div><br></div><div>I have one last =
question while reviewing my polyfill implementation. Is it worth=C2=A0it ad=
ding a SensitiveParameter attribute on the argument of the following method=
s ?</div><div><br></div><div>- Uri\Rfc3986\Uri::withUserInfo=C2=A0</div><di=
v>- Uri\WhatWg\Url::withPassword</div><div><br></div><div>I&#39;m fine with=
 any answer ? Does it warrant a paragraph in the RFC ? That I do not know b=
ut I feel the question may be raised ?</div><div><br></div><div>Best regard=
s,</div><div>Ignace Nyamagana Butera</div></div><br><div class=3D"gmail_quo=
te gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Apr=
 28, 2025 at 11:31=E2=80=AFPM ignace nyamagana butera &lt;<a href=3D"mailto=
:nyamsprod@gmail.com">nyamsprod@gmail.com</a>&gt; wrote:<br></div><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div>Hi Mat=C3=A9=
,</div><div><br></div><div>&gt; I fiddled a little bit with the implementat=
ion, and I went with the Uri\UriComparisonMode enum name at last. I hope th=
at it=C2=A0is OK on=C2=A0your side.</div><div><br></div>If no one objects w=
ith your name choice I am fine with it, as long as it is not a boolean :)=
=C2=A0 I will adapt my polyfill. I think I have no more remarks=C2=A0from m=
y side of things, great job! Since I do not have=C2=A0 the right to vote I =
hope this one will pass when time for voting comes!</div><br><div class=3D"=
gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Apr 28, 2025 at =
11:21=E2=80=AFPM M=C3=A1t=C3=A9 Kocsis &lt;<a href=3D"mailto:kocsismate90@g=
mail.com" target=3D"_blank">kocsismate90@gmail.com</a>&gt; wrote:<br></div>=
<blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-=
left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=
=3D"ltr">Hi Ignace,<div><br></div></div><div class=3D"gmail_quote"><blockqu=
ote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px=
 solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">The $excludeFrag=
ment is `true` by default so in the example it should be `false` instead. P=
erhaps using an Enum instead would make the DX=C2=A0easier=C2=A0than using =
a boolean ?<div>I believe the same issue is in all examples regarding the u=
se of that parameter.</div></div></blockquote><div><br></div><div>You are=
=C2=A0right, I completely messed up the value of the $excludeFragment varia=
bles in the examples. After having thought=C2=A0about your suggestion, I=
9;m fine with adding the enum.</div><div>It&#39;s a bit verbose indeed, but=
 at least it properly conveys the meaning of the parameter, so hopefully it=
 will reduce the number of WTFs when people start to use the new API. :)</d=
iv><div><br></div><div>I fiddled a little bit with the implementation, and =
I went with the Uri\UriComparisonMode enum name at last. I hope that it=C2=
=A0is OK on=C2=A0your side.</div><div><br></div><div>Regards,</div><div>M=
=C3=A1t=C3=A9</div></div></div>
</blockquote></div>
</blockquote></div>

--0000000000006bd8870633e6f429--