Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127232
Precedence: bulk
MIME-Version: 1.0
References: <CAH5C8xUb1O20ZDrOQNC=ckFxHUUWSK7sw_njQQzFBd0qgQqoww@mail.gmail.com>
 <CAOV5rgYZ_s1of-igLFEK7oqqh6=3HeYv0=JvvKvvjkcp0F6Q9Q@mail.gmail.com>
 <CAH5C8xV67frqOBCvLt73RM7QO86_pu40sHP5h71_kDRbKPtA8Q@mail.gmail.com>
 <1BCB4144-231D-45EA-A914-98EE8F0F503A@automattic.com> <8E614C9C-BA85-45D8-9A4E-A30D69981C5D@automattic.com>
 <CAH5C8xV69pHnSKWJrVB8EQab7vPhcaXAwYezoG6z3Oj7ZkXBaQ@mail.gmail.com>
 <bc5472e39bc607e2c7accc9d2bd6f239@bastelstu.be> <CAH5C8xW_auVf+ig7odhTK8dVWwmXTg4ZVZN-0Fhh4SUBzrWxVw@mail.gmail.com>
 <8df04e01-deac-404b-beb7-cd982423db63@bastelstu.be> <CAH5C8xU0JcnmC2Hdd=Hj0CQUaL0-LN=1X8+5-eUbFH3ZMxCvBA@mail.gmail.com>
 <33427cd03035ef084245c44290b56a55@bastelstu.be> <CAH5C8xXwDO6Ui8pLmqoxEguURh97fAaL4CfLK-oitqC85N7+8w@mail.gmail.com>
 <0aa1eefc3941bdea0092e935074daa58@bastelstu.be> <CAH5C8xU+rnp4e5=CzqhEncRww6nhZ7x1s68NjWtu+HQMpoNZ8g@mail.gmail.com>
 <76d96ea8a78c6025128c0a4b01c94c0a@bastelstu.be> <CAH5C8xXLPoRLJ6_dtotMtOv2NWs4LFzu+Kpr5A56Xk8wmuPDEg@mail.gmail.com>
 <07a8a580-4f0c-4b2f-8a67-b91dacfe99bf@bastelstu.be> <CAOV5rgZZgSjGWFdhWm7qwiRxeRMvf7ScgoPZZEXgnvK8Qyw38w@mail.gmail.com>
In-Reply-To: <CAOV5rgZZgSjGWFdhWm7qwiRxeRMvf7ScgoPZZEXgnvK8Qyw38w@mail.gmail.com>
Date: Mon, 28 Apr 2025 23:20:57 +0200
Message-ID: <CAH5C8xWSaSXDoXJ-18WptA-dN6Tt6N-DUwLk6PxR1ERP_pwSLA@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add WHATWG compliant URL parsing API
To: ignace nyamagana butera <nyamsprod@gmail.com>
Cc: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>, 
	Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000377da80633dd4340"
From: kocsismate90@gmail.com (=?UTF-8?B?TcOhdMOpIEtvY3Npcw==?=)

--000000000000377da80633dd4340
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Ignace,

The $excludeFragment is `true` by default so in the example it should be
> `false` instead. Perhaps using an Enum instead would make the
> DX easier than using a boolean ?
> I believe the same issue is in all examples regarding the use of that
> parameter.
>

You are right, I completely messed up the value of the $excludeFragment
variables in the examples. After having thought about your suggestion, I'm
fine with adding the enum.
It's a bit verbose indeed, but at least it properly conveys the meaning of
the parameter, so hopefully it will reduce the number of WTFs when people
start to use the new API. :)

I fiddled a little bit with the implementation, and I went with the
Uri\UriComparisonMode enum name at last. I hope that it is OK on your side.

Regards,
M=C3=A1t=C3=A9

--000000000000377da80633dd4340
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi Ignace,<div><br></div></div><div class=
=3D"gmail_quote gmail_quote_container"><blockquote class=3D"gmail_quote" st=
yle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padd=
ing-left:1ex"><div dir=3D"ltr">The $excludeFragment is `true` by default so=
 in the example it should be `false` instead. Perhaps using an Enum instead=
 would make the DX=C2=A0easier=C2=A0than using a boolean ?<div>I believe th=
e same issue is in all examples regarding the use of that parameter.</div><=
/div></blockquote><div><br></div><div>You are=C2=A0right, I completely mess=
ed up the value of the $excludeFragment variables in the examples. After ha=
ving thought=C2=A0about your suggestion, I&#39;m fine with adding the enum.=
</div><div>It&#39;s a bit verbose indeed, but at least it properly conveys =
the meaning of the parameter, so hopefully it will reduce the number of WTF=
s when people start to use the new API. :)</div><div><br></div><div>I fiddl=
ed a little bit with the implementation, and I went with the Uri\UriCompari=
sonMode enum name at last. I hope that it=C2=A0is OK on=C2=A0your side.</di=
v><div><br></div><div>Regards,</div><div>M=C3=A1t=C3=A9</div></div></div>

--000000000000377da80633dd4340--