Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:127218 X-Original-To: internals@lists.php.net Delivered-To: internals@lists.php.net Received: from php-smtp4.php.net (php-smtp4.php.net [45.112.84.5]) by qa.php.net (Postfix) with ESMTPS id C9A481A00BC for ; Mon, 28 Apr 2025 07:05:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=php.net; s=mail; t=1745823805; bh=GaK0c9g9NzN87OAL/Z7BXneQv/B7T+tRWBSajPqFVRI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=fBLxX99jobC7UptdqF/h68y7hSuVQo7vVIoHpVP4VLxC2vQ7sRNzb3fN7zXCLUAIt HTPrXcKeJbxg8NAf8PLm3fHJ2UMtjg5SCMa0ihY+IoTHZgGOcq9ODr0JY+yPkeLTkF ifFG84s/yRZNgchwcoYcxAJUHsqAoBMmkREnzK8lb7R09+05abrRmzAbcnjAb2dHgI 9P7J72heI96vkDMpR7/zRSOe7UTwp2Hs7fxo2rXqUSnHFyLMWNt1WUNP7f+Q6H5fH0 Ft4JD3Aei8hAuoDvgkoSC1p6v/J4GcTDwmRAj2kM1hgpspPXHF7U6+MZX9Wc+jErMX 10xCPytP5mLnw== Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 7D49818006D for ; Mon, 28 Apr 2025 07:03:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,FREEMAIL_FROM, HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=4.0.0 X-Spam-Virus: Error (Cannot connect to unix socket '/var/run/clamav/clamd.ctl': connect: Connection refused) X-Envelope-From: Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Mon, 28 Apr 2025 07:03:24 +0000 (UTC) Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-301c4850194so3581991a91.2 for ; Mon, 28 Apr 2025 00:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745823941; x=1746428741; darn=lists.php.net; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=GaK0c9g9NzN87OAL/Z7BXneQv/B7T+tRWBSajPqFVRI=; b=FCvuCME7in3IhkuOco0Iq4aznu8UrybmtnDA38UvyFqyOEItV2OkfVFfwTwSogHj6D PsAmOExbSIfAESrETmrv2J7H8yhKesrpHVwmAlb6xcEvvbwYj15FihA63cfj7CusGClh mhTma1dF7UI0n3U0+VxP+lMulyw3Ffj688j05eTanupObENIVzt7zUZY+6X4X8AdRPUD mkOreh0YxKwg/0jeePr/soFF4Fhc1u5xyNdfaHmuK1DGO16BShnze8sEkW53q+S0u8J/ 9lwl86Non314BCp+Ru5ictd8pl3PKneAQflXxGBMOifSxnXrRU340Rqj/jsdk1TMMdg0 zTbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745823941; x=1746428741; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GaK0c9g9NzN87OAL/Z7BXneQv/B7T+tRWBSajPqFVRI=; b=SjGJ2WUbi+1Fn7hSAfx0zWbu5+P4HK/j7VmzUCYstJu7FAqYTsflBDjd0OMLR5g60U U9MGaBM6wk776Rx04+9OZVAhggvhhpBAELnjOsR8853nmIeXeTxflUFvE/Io6q+l/m0Q /YxAK0DpC6LPzHHTCwzYAyJaxMHSfiI3bcyaFYZykFuNw98WtRl+ezCJniMiIv3SuqaF 2aHooIGzX4M8+R+9mPAOQn6jafkkvbQ4PHHgiSgcBnn/L2AAK35kCF4Cu7XcXVu6niGZ zPim9xvfUb5F16lnjrgp3K88hRhi/vRi8m80R9Ue3EsTzUaqkKcCUorxcYSjdNliPeSH kn8w== X-Forwarded-Encrypted: i=1; AJvYcCVo0cI9fOxbzQPhyUrVap78xN+bdx6xuV6vQlbDyermaWD9uRtyhZ7vDbPqSqTc6gtpU/+9QkF1Yj8=@lists.php.net X-Gm-Message-State: AOJu0YzWGTKUUTH9Ou76pZjdMRRL1iggvm6vH/XZV9PQ9L3ba4E2r/db ENnrlP9fsxNzljztLWA3JPBp3AhGwUV8gy5Q+KushCgq5gDNOIgoj5i79kLxdOG0cibbIXGLXym 0LFLATcpvmy+S7cGNPQNuvXP/OI8= X-Gm-Gg: ASbGncuOB5sWxAjkVCmcIl5l7j4WWnLUEf/2lVAAj8rYieXCQCkrAp7VDRZyMgczxDx uRa5tsyl3fg2b+fOak5wnWgvtT6g7wMkygLEoGoijU633AC/5pNGvTPZaepZBjC8o84wWd3S3zH LXLR60uTF+WfuZT+SA33hQ8hKo+y41rg9jt6y+oBsAR19sGeOFgH6cJA== X-Google-Smtp-Source: AGHT+IHObUDcSlKFy6IRpcZLqikWUBi4mJFQ0GafGyVZJWt1mBbPTDJX6JZl5rleYD4/8sU/CzUXgJOtQ3OtZ9gvS7Q= X-Received: by 2002:a17:90b:2f0f:b0:2eb:140d:f6df with SMTP id 98e67ed59e1d1-30a012ed038mr11877480a91.1.1745823940660; Mon, 28 Apr 2025 00:05:40 -0700 (PDT) Precedence: bulk list-help: list-post: List-Id: internals.lists.php.net x-ms-reactions: disallow MIME-Version: 1.0 References: <1BCB4144-231D-45EA-A914-98EE8F0F503A@automattic.com> <8E614C9C-BA85-45D8-9A4E-A30D69981C5D@automattic.com> <8df04e01-deac-404b-beb7-cd982423db63@bastelstu.be> <33427cd03035ef084245c44290b56a55@bastelstu.be> <0aa1eefc3941bdea0092e935074daa58@bastelstu.be> <76d96ea8a78c6025128c0a4b01c94c0a@bastelstu.be> <07a8a580-4f0c-4b2f-8a67-b91dacfe99bf@bastelstu.be> In-Reply-To: <07a8a580-4f0c-4b2f-8a67-b91dacfe99bf@bastelstu.be> Date: Mon, 28 Apr 2025 09:05:29 +0200 X-Gm-Features: ATxdqUH8w6K6cfK5unIQrxRMR-jR6DJ7_Hs_MC1Srvu_cxM8DQHtdmQD78jg7uU Message-ID: Subject: Re: [PHP-DEV] [RFC] [Discussion] Add WHATWG compliant URL parsing API To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= Cc: =?UTF-8?B?TcOhdMOpIEtvY3Npcw==?= , Internals Content-Type: multipart/alternative; boundary="000000000000d2d1550633d14faa" From: nyamsprod@gmail.com (ignace nyamagana butera) --000000000000d2d1550633d14faa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Mat=C3=A9, I found another typo in the RFC examples due to the use of boolean as parameters // The fragment component of Uri\WhatWg\Url can also be taken into account$url =3D new Uri\WhatWg\Url("https://example.com#foo");$url->equals(new Uri\WhatWg\Url("https://example.com"), true); // false The $excludeFragment is `true` by default so in the example it should be `false` instead. Perhaps using an Enum instead would make the DX easier than using a boolean ? I believe the same issue is in all examples regarding the use of that parameter. Best regards, Ignace Nyamagana Butera On Mon, Apr 28, 2025 at 12:35=E2=80=AFAM Tim D=C3=BCsterhus wrote: > Hi > > On 4/27/25 23:47, M=C3=A1t=C3=A9 Kocsis wrote: > > [=E2=80=A6] > > Thank you. I have just given the RFC another full read (the 2025/04/27 > 21:44 version) and I do not have any further remarks. I'm happy with > everything that is said in the RFC and I'm really looking forward to > vote =E2=80=9CYes=E2=80=9D :-) > > Best regards > Tim D=C3=BCsterhus > --000000000000d2d1550633d14faa Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Mat=C3=A9,

<= /div>
I found another typo in the RFC examples due to the u= se of boolean as parameters=C2=A0

// The fragment com=
ponent of Uri\WhatWg\Url can also be taken into account
$url =3D new Uri\WhatWg\Url("https://example.com#foo");
$url->equals(new Uri\WhatWg\Url("https://example.com"), true); // false
The $e= xcludeFragment is `true` by default so in the example it should be `false` = instead. Perhaps using an Enum instead would make the DX=C2=A0easier=C2=A0t= han using a boolean ?
I believe the same issue is in all examples regar= ding the use of that parameter.

Best regards,
<= div>Ignace Nyamagana Butera


On Mon, = Apr 28, 2025 at 12:35=E2=80=AFAM Tim D=C3=BCsterhus <tim@bastelstu.be> wrote:
Hi

On 4/27/25 23:47, M=C3=A1t=C3=A9 Kocsis wrote:
> [=E2=80=A6]

Thank you. I have just given the RFC another full read (the 2025/04/27
21:44 version) and I do not have any further remarks. I'm happy with everything that is said in the RFC and I'm really looking forward to vote =E2=80=9CYes=E2=80=9D :-)

Best regards
Tim D=C3=BCsterhus
--000000000000d2d1550633d14faa--