Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127208
Message-ID: <99d8eacb-1058-44d2-b6e1-314846d59e54@bastelstu.be>
Date: Sun, 27 Apr 2025 22:32:44 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add WHATWG compliant URL parsing API
To: ignace nyamagana butera <nyamsprod@gmail.com>,
 =?UTF-8?B?TcOhdMOpIEtvY3Npcw==?= <kocsismate90@gmail.com>,
 PHP Internals List <internals@lists.php.net>
References: <CAH5C8xUb1O20ZDrOQNC=ckFxHUUWSK7sw_njQQzFBd0qgQqoww@mail.gmail.com>
 <CAOV5rgYZ_s1of-igLFEK7oqqh6=3HeYv0=JvvKvvjkcp0F6Q9Q@mail.gmail.com>
 <CAH5C8xV67frqOBCvLt73RM7QO86_pu40sHP5h71_kDRbKPtA8Q@mail.gmail.com>
 <1BCB4144-231D-45EA-A914-98EE8F0F503A@automattic.com>
 <8E614C9C-BA85-45D8-9A4E-A30D69981C5D@automattic.com>
 <CAH5C8xV69pHnSKWJrVB8EQab7vPhcaXAwYezoG6z3Oj7ZkXBaQ@mail.gmail.com>
 <bc5472e39bc607e2c7accc9d2bd6f239@bastelstu.be>
 <CAH5C8xW_auVf+ig7odhTK8dVWwmXTg4ZVZN-0Fhh4SUBzrWxVw@mail.gmail.com>
 <8df04e01-deac-404b-beb7-cd982423db63@bastelstu.be>
 <CAH5C8xU0JcnmC2Hdd=Hj0CQUaL0-LN=1X8+5-eUbFH3ZMxCvBA@mail.gmail.com>
 <33427cd03035ef084245c44290b56a55@bastelstu.be>
 <CAH5C8xXwDO6Ui8pLmqoxEguURh97fAaL4CfLK-oitqC85N7+8w@mail.gmail.com>
 <0aa1eefc3941bdea0092e935074daa58@bastelstu.be>
 <CAH5C8xU+rnp4e5=CzqhEncRww6nhZ7x1s68NjWtu+HQMpoNZ8g@mail.gmail.com>
 <76d96ea8a78c6025128c0a4b01c94c0a@bastelstu.be>
 <CAOV5rgbYk7xZShs1933JR29NKr_MSCRqvkTdzn0Wpt4ejAC8TQ@mail.gmail.com>
Content-Language: en-US
In-Reply-To: <CAOV5rgbYk7xZShs1933JR29NKr_MSCRqvkTdzn0Wpt4ejAC8TQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 4/27/25 22:30, ignace nyamagana butera wrote:
> $url = Uri\WhatWg\Url::parse("/foo", ".com");                 //
> Throws Uri\WhatWg\InvalidUrlException because of $baseUri
> 
> Since parse is used shouldn't it return null instead of throwing ?

In this case the `$baseUri` is invalid. Since this is not expected to be 
an untrusted value, it makes sense to me to throw an 
`InvalidUrlException` here. The `null` return should only be used for an 
invalid `$uri`.

Best regards
Tim Düsterhus