Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127111
Content-Type: multipart/alternative;
 boundary="------------Efhamh40ztvjrtdZjxa2UpcS"
Message-ID: <2c9fc329-8b90-46e8-90ff-f4c4715ee063@seld.be>
Date: Tue, 15 Apr 2025 10:13:17 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] New max_memory_limit INI setting
To: Ilija Tovilo <tovilo.ilija@gmail.com>,
 PHP internals <internals@lists.php.net>
References: <CAPyj-LC=61xKVNOx+VJYk21p_6R4-YHVuSus5sCnCPUvDCS4Qw@mail.gmail.com>
Content-Language: fr
In-Reply-To: <CAPyj-LC=61xKVNOx+VJYk21p_6R4-YHVuSus5sCnCPUvDCS4Qw@mail.gmail.com>
From: j.boggiano@seld.be (Jordi Boggiano)

This is a multi-part message in MIME format.
--------------Efhamh40ztvjrtdZjxa2UpcS
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 14.04.2025 14:41, Ilija Tovilo wrote:
> One open question is whether exceeding the max_memory_limit should
> also set memory_limit to max_memory_limit in addition to warning,
> giving the subsequent operation a higher chance not to straight out
> OOM error. Let me know if you have a preference in that regard.

I'd say absolutely yes it should respect the requested memory limit as 
much as possible.

Especially when setting memory_limit to -1 you'd definitely want this to 
mean "use the max allowed memory limit" and perhaps even skip the 
warning in that case as it's not a very specific request for a memory 
amount.

Best,
Jordi

-- 
Jordi Boggiano
@seldaek -https://seld.be

--------------Efhamh40ztvjrtdZjxa2UpcS
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">On 14.04.2025 14:41, Ilija Tovilo
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAPyj-LC=61xKVNOx+VJYk21p_6R4-YHVuSus5sCnCPUvDCS4Qw@mail.gmail.com">
      <pre wrap="" class="moz-quote-pre">One open question is whether exceeding the max_memory_limit should
also set memory_limit to max_memory_limit in addition to warning,
giving the subsequent operation a higher chance not to straight out
OOM error. Let me know if you have a preference in that regard.</pre>
    </blockquote>
    <p>I'd say absolutely yes it should respect the requested memory
      limit as much as possible. </p>
    <p>Especially when setting memory_limit to -1 you'd definitely want
      this to mean "use the max allowed memory limit" and perhaps even
      skip the warning in that case as it's not a very specific request
      for a memory amount.</p>
    <p>Best,<br>
      Jordi<span style="white-space: pre-wrap">
</span></p>
    <pre class="moz-signature" cols="72">-- 
Jordi Boggiano
@seldaek - <a class="moz-txt-link-freetext" href="https://seld.be">https://seld.be</a></pre>
  </body>
</html>

--------------Efhamh40ztvjrtdZjxa2UpcS--