Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127079
Message-ID: <0654c99d-f6ec-4953-aa55-a603ff06913c@gmail.com>
Date: Wed, 9 Apr 2025 00:21:57 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [RFC] [Discussion] array_first() and array_last()
To: PHP internals <internals@lists.php.net>
References: <51fcec92-b2ae-482e-920f-c6c991b526c5@gmail.com>
 <e17368e7-1210-4cd2-8213-1fe7b5b3ef13@daikaras.lt>
Content-Language: en-US
In-Reply-To: <e17368e7-1210-4cd2-8213-1fe7b5b3ef13@daikaras.lt>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
From: dossche.niels@gmail.com (Niels Dossche)

On 4/8/25 10:53 AM, Daikaras wrote:
> On 4/5/2025 6:51 PM, Niels Dossche wrote:
>> Hi internals
>>
>> I'm opening the discussion for the RFC "array_first() and array_last()".
>> https://wiki.php.net/rfc/array_first_last
>>
>> Kind regards
>> Niels
> 
> 
> -1 because returning `null` for empty arrays is still wrong. Whatever similar behavior exists should be corrected to throw `ValueError` in the future. Just my 2c.
> 

I think consistency is very important, hence I will stick to my reasoning why returning NULL is the right thing at the moment.
If the behaviour of array functions on empty arrays is ever revised in the future, then we should keep everything consistent. So e.g. if a _future_ RFC decides to make array access throw instead of yield NULL, then this should affect array_{first,last} too IMO. However, that's not for now, that's a lot of ifs and hypothetical future development. That discussion should happen in the future elsewhere.