Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127044
Content-Type: multipart/alternative;
 boundary="------------az9hZd390p5NKqBGTcft82ke"
Message-ID: <5003143b-450a-4404-9cd4-4ecb4d63690f@gmail.com>
Date: Fri, 4 Apr 2025 19:46:55 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add WHATWG compliant URL parsing API
To: =?UTF-8?B?TcOhdMOpIEtvY3Npcw==?= <kocsismate90@gmail.com>
Cc: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>,
 PHP Internals List <internals@lists.php.net>
References: <CAH5C8xUb1O20ZDrOQNC=ckFxHUUWSK7sw_njQQzFBd0qgQqoww@mail.gmail.com>
 <CAH5C8xV67frqOBCvLt73RM7QO86_pu40sHP5h71_kDRbKPtA8Q@mail.gmail.com>
 <1BCB4144-231D-45EA-A914-98EE8F0F503A@automattic.com>
 <8E614C9C-BA85-45D8-9A4E-A30D69981C5D@automattic.com>
 <CAH5C8xV69pHnSKWJrVB8EQab7vPhcaXAwYezoG6z3Oj7ZkXBaQ@mail.gmail.com>
 <bc5472e39bc607e2c7accc9d2bd6f239@bastelstu.be>
 <9bf11a89-39d9-457b-b0ea-789fd07d7370@gmail.com>
 <CAH5C8xWnoytE=jm1sxr-HcSZFzmG8SrzghinmBZa-QyGqN4uUg@mail.gmail.com>
 <6430b9ed-638d-4247-9fa9-d1a9148c382b@gmail.com>
 <CAH5C8xX3tCS3B3z2YFbRudCXi=ZNHE0scrmoFO7cXxU773EfpA@mail.gmail.com>
 <2e95e8fe-7cf0-493f-bd0a-9fff0956baaa@gmail.com>
 <CAH5C8xXuSEBx6y4ds8bhReFFZe0i05DFonvEP+sz+mdkembZtQ@mail.gmail.com>
 <f5952335-898a-4707-aa6e-7668b678ff13@gmail.com>
 <7d715757cc2dfd71019d106b01c69aed@bastelstu.be>
 <b6068753-b542-4e11-96fd-683f1614ea3b@gmail.com>
 <fb618e90-15ef-4dcc-b364-ea17499986ca@gmail.com>
 <CAH5C8xWMW4Uw7JdFhaLCqbiYk=uPa0fWWgQuD5xKMg8Fgdfmug@mail.gmail.com>
Content-Language: fr
In-Reply-To: <CAH5C8xWMW4Uw7JdFhaLCqbiYk=uPa0fWWgQuD5xKMg8Fgdfmug@mail.gmail.com>
From: nyamsprod@gmail.com (Ignace Nyamagana Butera)

This is a multi-part message in MIME format.
--------------az9hZd390p5NKqBGTcft82ke
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 02/04/2025 19:59, Máté Kocsis wrote:
> Hi Ignace,
>
>     I spotted another inconsistency in the normalization under RFC3986
>
>
> Thanks for spotting this: apparently, it is due to a small bug in the 
> uriparser library, which I managed to fix locally, PR is on its way to 
> upstream.
>
> Máté


Hi Máté I have a couple of questions regarding RFC3986\Uri

- I believe during normalization of IPv6 host the letter a-f should be 
lowercase in accordance with the RFC since

RFC3986 follows https://www.rfc-editor.org/rfc/rfc3513 which has been 
replaced by https://www.rfc-editor.org/rfc/rfc4291 which is updated by 
https://www.rfc-editor.org/rfc/rfc5952#section-4.3 which recommends 
lowecasing the letters. (yeah that was quite a digging I know 🙂 )

- Since the withers expect well encoded components does it means that it 
is the same for the constructor. What is

the expected result for the following code ?

```php

$uri =new Uri\Rfc3986\Uri("https://example,com/?foo[]=1&foo[]=2");
```

Should the above trigger an exception because the query component contain invalid characters or
is it acceptable ? Asking because currently our dear old parse_url does not fail on this and
probably most PHP developers expect this not to fail.

IMHO I am in favor of it failing to get a consistent experience when using the class because
otherwse you introduce an inconsistency between the constructor behaviour and the rest of the class
API.

Best regards,
Ignace Nyamagana Butera


--------------az9hZd390p5NKqBGTcft82ke
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 02/04/2025 19:59, Máté Kocsis wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAH5C8xWMW4Uw7JdFhaLCqbiYk=uPa0fWWgQuD5xKMg8Fgdfmug@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <div dir="ltr">
        <div dir="ltr">Hi Ignace,</div>
        <div class="gmail_quote gmail_quote_container">
          <blockquote class="gmail_quote"
style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
            <div>
              <p>I spotted another inconsistency in the normalization
                under RFC3986</p>
            </div>
          </blockquote>
          <div><br>
          </div>
          <div>Thanks for spotting this: apparently, it is due to a
            small bug in the uriparser library, which I managed to fix
            locally, PR is on its way to upstream.</div>
          <div><br>
          </div>
          <div>Máté</div>
        </div>
      </div>
    </blockquote>
    <p><br>
    </p>
    <p>Hi Máté I have a couple of questions regarding RFC3986\Uri <br>
    </p>
    <p>- I believe during normalization of IPv6 host the letter a-f
      should be lowercase in accordance with the RFC since <br>
    </p>
    <p>RFC3986 follows <a class="moz-txt-link-freetext" href="https://www.rfc-editor.org/rfc/rfc3513">https://www.rfc-editor.org/rfc/rfc3513</a> which has
      been replaced by <a class="moz-txt-link-freetext" href="https://www.rfc-editor.org/rfc/rfc4291">https://www.rfc-editor.org/rfc/rfc4291</a> which is
      updated by <a class="moz-txt-link-freetext" href="https://www.rfc-editor.org/rfc/rfc5952#section-4.3">https://www.rfc-editor.org/rfc/rfc5952#section-4.3</a>
      which recommends lowecasing the letters. (yeah that was quite a
      digging I know 🙂 )<br>
    </p>
    <p>- Since the withers expect well encoded components does it means
      that it is the same for the constructor. What is</p>
    <p>the expected result for the following code ?<br>
    </p>
    <p>```php</p>
    <div style="background-color:#ffffff;color:#080808">
      <pre
      style="font-family:'JetBrains Mono',monospace;font-size:9,8pt;"><span
      style="color:#660000;">$uri </span>= <span style="color:#0033b3;">new </span><span
      style="color:#000000;">Uri</span>\<span style="color:#000000;">Rfc3986</span>\<span
      style="color:#000000;">Uri</span>(<span style="color:#067d17;"><a class="moz-txt-link-rfc2396E" href="https://example,com/?foo[]=1&amp;foo[]=2">"https://example,com/?foo[]=1&amp;foo[]=2"</a></span>);
```

Should the above trigger an exception because the query component contain invalid characters or
is it acceptable ? Asking because currently our dear old parse_url does not fail on this and
probably most PHP developers expect this not to fail.

IMHO I am in favor of it failing to get a consistent experience when using the class because
otherwse you introduce an inconsistency between the constructor behaviour and the rest of the class
API.

Best regards,
Ignace Nyamagana Butera
</pre>
    </div>
    <p></p>
    <p><br>
    </p>
  </body>
</html>

--------------az9hZd390p5NKqBGTcft82ke--