Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:127031
Precedence: bulk
MIME-Version: 1.0
Date: Thu, 03 Apr 2025 12:26:29 +0200
To: Volker Dusch <volker@tideways-gmbh.com>
Cc: php internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] Re: [VOTE] Marking return values as important
 (#[\NoDiscard])
In-Reply-To: <CAMzRQTeD22ZsozMBbxp1yZbpdD_StwmEr-g5-Xp8bG6mduZ4bg@mail.gmail.com>
References: <CAMzRQTdzzxU3e9W5+1FoeJS=g8bPUB4EJP0o-WE++EvrvLz4jQ@mail.gmail.com>
 <CAMzRQTeD22ZsozMBbxp1yZbpdD_StwmEr-g5-Xp8bG6mduZ4bg@mail.gmail.com>
Message-ID: <7d4f724f1287a120f0aaf63ad605faed@bastelstu.be>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

Am 2025-03-19 15:01, schrieb Volker Dusch:
> Tim will take care of finalizing the implementation in the coming days.

The implementation was merged yesterday and the nightly tests of Symfony 
/ PHPUnit / Composer exposed that the `LOCK_UN` case of `flock()` was 
not considered when applying the attribute to `flock()`. Issue #18235 
was filed in PHP’s tracker, proposing to remove the attribute from 
`flock()` (keeping the attribute itself and keeping it on the 
DateTimeImmutable setters):

https://github.com/php/php-src/issues/18235

Unless someone objects with that and requests a follow-up vote, I'll 
send a PR to remove the attribute from `flock()` by “informal agreement” 
in the next days.

Best regards
Tim Düsterhus