Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126905
Content-Type: text/plain;
	charset=utf-8
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\))
Subject: Re: [PHP-DEV] Potential RFC: mb_rawurlencode() ?
In-Reply-To: <e9150497f5cb41fab412020c163f0990@bastelstu.be>
Date: Sat, 22 Mar 2025 08:43:11 -0500
Cc: PHP Internals List <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <4BDB76B7-1EBE-4063-BD88-3B0750D07E67@pmjones.io>
References: <C47E5955-E75E-49A7-88D3-6957669057F0@pmjones.io>
 <e9150497f5cb41fab412020c163f0990@bastelstu.be>
To: =?utf-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
From: pmjones@pmjones.io ("Paul M. Jones")

Hi Tim & all,

> On Mar 21, 2025, at 06:22, Tim D=C3=BCsterhus <tim@bastelstu.be> =
wrote:
>=20
> Am 2025-03-18 18:48, schrieb Paul M. Jones:
>> $iriPath =3D '/heads/' . rawurlencode($val) . '/tails/');
>> assert($iriPath =3D=3D=3D '/heads/f=C3=BC bar/tails/'; // false
>=20
> =46rom my reading of RFC 3987 that result is incorrect. The space is =
neither listed as `iunreserved`, not as `sub-delims`, thus isn't a valid =
`ipchar`. Thus the space needs to be encoded as %20 for IRIs as well. =
The same mistake applies to the reference userland implementation below.

Agreed; the naive implementation would need to less naive and pay closer =
attention to the ABNF for `ucschar` and `ipchar` in the spec.

Along those lines, I think there might need to be two additional =
changes/additions to help with encoding for RFC 3987 and WHATWG-URL =
component values:

- `http_build_query()` would need PHP_QUERY_3987 and PHP_QUERY_WHATWG =
flags and corresponding logic (or entirely new functions); and
- `parse_str()` would need a corresponding `mb_parse_str()`.


-- pmj