Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126900
Precedence: bulk
MIME-Version: 1.0
References: <CALaXqqQdpEg-+FHMkkpvWaMmoqDuHhVri+mU7W=q1KuCQO80-w@mail.gmail.com>
 <CALaXqqSa4VhAMWjTdmFvOgRJQt_AZEa+m=n+p0v7RfsXj+0FaQ@mail.gmail.com>
 <250fd68437fe3025e3aad9eff271dde3@bastelstu.be> <CALaXqqQivJyD1BSOSTnHa+TweN=yRbvanY74wd9F=Z3czhSenA@mail.gmail.com>
In-Reply-To: <CALaXqqQivJyD1BSOSTnHa+TweN=yRbvanY74wd9F=Z3czhSenA@mail.gmail.com>
Date: Fri, 21 Mar 2025 18:45:08 +0200
Message-ID: <CAAwdEzBc04S+rzi6=wypRaZ4KagNPnjQqksaZXCNx3eMrWBgwQ@mail.gmail.com>
Subject: Re: [PHP-DEV] Re: Constructor property promotion for final properties
To: Daniel Scherzer <daniel.e.scherzer@gmail.com>
Cc: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>, internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000491d1a0630dcfb76"
From: drealecs@gmail.com (=?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?=)

--000000000000491d1a0630dcfb76
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 21, 2025 at 5:20=E2=80=AFPM Daniel Scherzer <daniel.e.scherzer@=
gmail.com>
wrote:

> On Fri, Mar 21, 2025 at 4:07=E2=80=AFAM Tim D=C3=BCsterhus <tim@bastelstu=
.be> wrote:
>
>> Can you clarify if the following would result in constructor property
>> promotion or not:
>>
>>      class Foo {
>>          public function __construct(
>>              final string $bar,
>>          ) { }
>>      }
>>
>> Best regards
>> Tim D=C3=BCsterhus
>>
>
> Yes, that would result in constructor property promotion. I'll need to
> retarget the original PR for master, but at
> https://github.com/php/php-src/pull/17861 you can see in
> `Zend/tests/property_hooks/final_prop_promoted_2.phpt` a very similar tes=
t
> case.
>
>
I see. Good catch Tim.
Daniel, you don't have this exact test case there.

Initially, in 8.0, only a visibility keyword would trigger the property
promotion logic.
Later, in 8.1, also the readonly keyword would trigger this and make the
property public, without the need to mention the visibility:
https://3v4l.org/Co0gl

Now we want the same for the final keyword, to trigger the property
promotion without having a visibility keyword,
because like readonly, it would not be applicable to a parameter, but just
to a property?

--=20
Alex

--000000000000491d1a0630dcfb76
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><div class=3D"gmail_quote gmail=
_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Mar 21, 202=
5 at 5:20=E2=80=AFPM Daniel Scherzer &lt;<a href=3D"mailto:daniel.e.scherze=
r@gmail.com">daniel.e.scherzer@gmail.com</a>&gt; wrote:<br></div><blockquot=
e class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px s=
olid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr">O=
n Fri, Mar 21, 2025 at 4:07=E2=80=AFAM Tim D=C3=BCsterhus &lt;<a href=3D"ma=
ilto:tim@bastelstu.be" target=3D"_blank">tim@bastelstu.be</a>&gt; wrote:</d=
iv><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:=
1ex">Can you clarify if the following would result in constructor property =
<br>
promotion or not:<br>
<br>
=C2=A0 =C2=A0 =C2=A0class Foo {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0public function __construct(<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0final string $bar,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0) { }<br>
=C2=A0 =C2=A0 =C2=A0}<br>
<br>
Best regards<br>
Tim D=C3=BCsterhus<br></blockquote><div><br></div><div>Yes, that would resu=
lt in constructor property promotion. I&#39;ll need to retarget the origina=
l PR for master, but at=C2=A0<a href=3D"https://github.com/php/php-src/pull=
/17861" target=3D"_blank">https://github.com/php/php-src/pull/17861</a> you=
 can see in `Zend/tests/property_hooks/final_prop_promoted_2.phpt` a very s=
imilar test case.</div><div><br></div></div></div></blockquote><div><br></d=
iv><div>I see. Good catch Tim.</div><div>Daniel, you don&#39;t have this ex=
act test case there.</div><div><br></div><div>Initially, in 8.0, only a vis=
ibility keyword would trigger the property promotion logic.</div><div>Later=
, in=C2=A08.1, also the readonly keyword would trigger this and make the pr=
operty public, without the need to mention the visibility:=C2=A0<a href=3D"=
https://3v4l.org/Co0gl">https://3v4l.org/Co0gl</a></div><div><br></div><div=
>Now we want the same for the final keyword, to trigger the property promot=
ion without having a visibility keyword,</div><div>because=C2=A0like readon=
ly, it would not be applicable=C2=A0to a parameter, but just to a property?=
</div><div><br></div><div>--=C2=A0</div><div>Alex</div></div></div>

--000000000000491d1a0630dcfb76--