Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126897
Precedence: bulk
MIME-Version: 1.0
References: <CALaXqqQdpEg-+FHMkkpvWaMmoqDuHhVri+mU7W=q1KuCQO80-w@mail.gmail.com>
 <CALaXqqSa4VhAMWjTdmFvOgRJQt_AZEa+m=n+p0v7RfsXj+0FaQ@mail.gmail.com> <250fd68437fe3025e3aad9eff271dde3@bastelstu.be>
In-Reply-To: <250fd68437fe3025e3aad9eff271dde3@bastelstu.be>
Date: Fri, 21 Mar 2025 08:17:05 -0700
Message-ID: <CALaXqqQivJyD1BSOSTnHa+TweN=yRbvanY74wd9F=Z3czhSenA@mail.gmail.com>
Subject: Re: [PHP-DEV] Re: Constructor property promotion for final properties
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="00000000000079eb730630dbc1ac"
From: daniel.e.scherzer@gmail.com (Daniel Scherzer)

--00000000000079eb730630dbc1ac
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 21, 2025 at 4:07=E2=80=AFAM Tim D=C3=BCsterhus <tim@bastelstu.b=
e> wrote:

> Can you clarify if the following would result in constructor property
> promotion or not:
>
>      class Foo {
>          public function __construct(
>              final string $bar,
>          ) { }
>      }
>
> Best regards
> Tim D=C3=BCsterhus
>

Yes, that would result in constructor property promotion. I'll need to
retarget the original PR for master, but at
https://github.com/php/php-src/pull/17861 you can see in
`Zend/tests/property_hooks/final_prop_promoted_2.phpt` a very similar test
case.

--Daniel

--00000000000079eb730630dbc1ac
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Fri, Mar 21, 2025 at 4:07=E2=80=AFAM T=
im D=C3=BCsterhus &lt;<a href=3D"mailto:tim@bastelstu.be">tim@bastelstu.be<=
/a>&gt; wrote:</div><div class=3D"gmail_quote gmail_quote_container"><block=
quote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1=
px solid rgb(204,204,204);padding-left:1ex">Can you clarify if the followin=
g would result in constructor property <br>
promotion or not:<br>
<br>
=C2=A0 =C2=A0 =C2=A0class Foo {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0public function __construct(<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0final string $bar,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0) { }<br>
=C2=A0 =C2=A0 =C2=A0}<br>
<br>
Best regards<br>
Tim D=C3=BCsterhus<br></blockquote><div><br></div><div>Yes, that would resu=
lt in constructor property promotion. I&#39;ll need to retarget the origina=
l PR for master, but at=C2=A0<a href=3D"https://github.com/php/php-src/pull=
/17861">https://github.com/php/php-src/pull/17861</a> you can see in `Zend/=
tests/property_hooks/final_prop_promoted_2.phpt` a very similar test case.<=
/div><div><br></div><div>--Daniel=C2=A0</div></div></div>

--00000000000079eb730630dbc1ac--