Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126878
Precedence: bulk
MIME-Version: 1.0
Date: Thu, 20 Mar 2025 22:04:15 +0200
To: Daniel Scherzer <daniel.e.scherzer@gmail.com>
Cc: internals@lists.php.net
Subject: Re: [PHP-DEV] [RFC] [Discussion] Never parameters
In-Reply-To: <CALaXqqQDMKju=TmSR4hruG1dr4qb4MTKrmcyQdXqGa2j5B_joQ@mail.gmail.com>
References: <CALaXqqRWL8ygMGoA5xnMtt7w6rE-5WJJZ5P9oiO3vHgqvod=Fw@mail.gmail.com>
 <CAJF_ukXsyh9k+JTOiuJvYJ5Brq41vYBb-8+Cg6rfH9yE459Pbg@mail.gmail.com>
 <CALaXqqQDMKju=TmSR4hruG1dr4qb4MTKrmcyQdXqGa2j5B_joQ@mail.gmail.com>
User-Agent: Roundcube Webmail/1.4.8
Message-ID: <17f97184100adbe822868f23251659a4@glaive.pro>
Organization: SIA "Glaive.pro"
Content-Type: multipart/alternative;
 boundary="=_485f3082c8467a81250020af3629707a"
From: juris@glaive.pro (Juris Evertovskis)

--=_485f3082c8467a81250020af3629707a
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
 format=flowed

On 2025-03-20 18:50, Daniel Scherzer wrote:

> The original inspiration which I discussed in the RFC is fixing the 
> signature of the BackedEnum methods, which currently use the second 
> option.
> 
>> 

Hey,

I'm not opposed to having a bottom type, but the `try`/`tryFrom` issue 
feels caused by another shortcoming.

In my view`from` and `tryFrom` are factory methods that construct an 
instance by being called on the class itself. As such they should not be 
subject to LSP at all, just like __construct is not.

BR,
Juris
--=_485f3082c8467a81250020af3629707a
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset=UTF-8

<html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; charset=
=3DUTF-8" /></head><body style=3D'font-size: 10pt; font-family: Verdana,Gen=
eva,sans-serif'>
<p id=3D"reply-intro">On 2025-03-20 18:50, Daniel Scherzer wrote:</p>
<blockquote type=3D"cite" style=3D"padding: 0 0.4em; border-left: #1010ff 2=
px solid; margin: 0">
<div id=3D"replybody1">
<div dir=3D"ltr">
<div class=3D"v1gmail_quote v1gmail_quote_container">
<div>&nbsp;</div>
<div>The original inspiration which I discussed in the RFC is fixing the si=
gnature of the BackedEnum methods, which currently use the second option.</=
div>
<blockquote class=3D"v1gmail_quote" style=3D"margin: 0px 0px 0px 0.8ex; bor=
der-left: 1px solid #cccccc; padding-left: 1ex;">
<div dir=3D"ltr">
<div>
<div>
<div dir=3D"ltr">
<div class=3D"v1gmail_quote">&nbsp;</div>
</div>
</div>
</div>
</div>
</blockquote>
<div>&nbsp;</div>
</div>
</div>
</div>
</blockquote>
<p>Hey,</p>
<p>I'm not opposed to having a bottom type, but the `try`/`tryFrom` issue f=
eels caused by another shortcoming.</p>
<p>In my view`from` and `tryFrom` are factory methods that construct an ins=
tance by being called on the class itself.&nbsp;As such they should not be =
subject to LSP at all, just like __construct is not.</p>
<p>BR,<br />Juris</p>

</body></html>

--=_485f3082c8467a81250020af3629707a--