Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126829
Precedence: bulk
MIME-Version: 1.0
References: <CAH5C8xUb1O20ZDrOQNC=ckFxHUUWSK7sw_njQQzFBd0qgQqoww@mail.gmail.com>
 <dd61999c-1ebd-4765-9add-cd8065968965@gmail.com> <CAOV5rgYZ_s1of-igLFEK7oqqh6=3HeYv0=JvvKvvjkcp0F6Q9Q@mail.gmail.com>
 <CAH5C8xV67frqOBCvLt73RM7QO86_pu40sHP5h71_kDRbKPtA8Q@mail.gmail.com>
 <1BCB4144-231D-45EA-A914-98EE8F0F503A@automattic.com> <8E614C9C-BA85-45D8-9A4E-A30D69981C5D@automattic.com>
 <CAH5C8xV69pHnSKWJrVB8EQab7vPhcaXAwYezoG6z3Oj7ZkXBaQ@mail.gmail.com>
 <bc5472e39bc607e2c7accc9d2bd6f239@bastelstu.be> <9bf11a89-39d9-457b-b0ea-789fd07d7370@gmail.com>
 <CAH5C8xWnoytE=jm1sxr-HcSZFzmG8SrzghinmBZa-QyGqN4uUg@mail.gmail.com>
 <6430b9ed-638d-4247-9fa9-d1a9148c382b@gmail.com> <CAH5C8xX3tCS3B3z2YFbRudCXi=ZNHE0scrmoFO7cXxU773EfpA@mail.gmail.com>
 <1FD11284-D682-4CB7-893F-D74A1904610D@pmjones.io>
In-Reply-To: <1FD11284-D682-4CB7-893F-D74A1904610D@pmjones.io>
Date: Tue, 18 Mar 2025 21:15:52 +0100
Message-ID: <CAH5C8xVGDhDgLp0QWabx6BudAvRAcF9sVt+gR0R0C-bF3E1hRw@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add WHATWG compliant URL parsing API
To: "Paul M. Jones" <pmjones@pmjones.io>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000084fb80630a39314"
From: kocsismate90@gmail.com (=?UTF-8?B?TcOhdMOpIEtvY3Npcw==?=)

--000000000000084fb80630a39314
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Paul,


> If we want a full-featured WHATWG-URL implementation in core, would it no=
t
> be preferable (with Trevor's permission) to convert rowbot/url from
> userland to core instead? Surely conversion from an existing, well-tested=
,
> widely-used implementation would be easier/better/faster than writing an
> implementation from scratch.
>

There's no way I would have written an implementation from scratch. I'm
using the url module of the Lexbor C library (
https://github.com/lexbor/lexbor/) for handling WHATWG URLs. It's already
bundled in core, and it's also battle tested, and it has exceptional
maintenance. All I had to implement is the glue between userland and the C
library.

M=C3=A1t=C3=A9

--000000000000084fb80630a39314
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><div>Hi P=
aul,</div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margi=
n:0px 0px 0px 0.8ex;border-left:1px solid rgb(77,77,77);padding-left:1ex">
If we want a full-featured WHATWG-URL implementation in core, would it not =
be preferable (with Trevor&#39;s permission) to convert rowbot/url from use=
rland to core instead? Surely conversion from an existing, well-tested, wid=
ely-used implementation would be easier/better/faster than writing an imple=
mentation from scratch.<br></blockquote><div><span style=3D"color:rgb(191,1=
91,191)"><br></span></div><div><span style=3D"color:rgb(191,191,191)">There=
&#39;s no way I would have written an implementation from scratch. I&#39;m =
using the url module of the Lexbor C library (</span><span style=3D"color:r=
gb(191,191,191)"><a href=3D"https://github.com/lexbor/lexbor/">https://gith=
ub.com/lexbor/lexbor/</a></span><span style=3D"color:rgb(191,191,191)">) fo=
r handling WHATWG URLs.  It&#39;s already bundled in core, and it&#39;s als=
o battle tested, and it has exceptional maintenance.=C2=A0</span><span styl=
e=3D"color:rgb(191,191,191)">All I had to implement is the glue between use=
rland and the C library.</span></div><div><span style=3D"color:rgb(191,191,=
191)"><br></span></div><div><span style=3D"color:rgb(191,191,191)">M=C3=A1t=
=C3=A9</span></div></div></div>

--000000000000084fb80630a39314--