Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126824
Precedence: bulk
MIME-Version: 1.0
References: <CAMW7n8DQqUhnb+U+WcA7bJ-APRDTtzuJC4m8s-q_2LH7bEuH+A@mail.gmail.com>
 <72bd5401-53a9-409f-ad45-687333401961@rwec.co.uk> <CAMW7n8De15X4xDNOBULKeKkpeCeNo-tDWVWZ+Zer8vMa3U-vQg@mail.gmail.com>
 <d50b892b-9372-45c0-81ad-1ce818385b75@rwec.co.uk> <CAMW7n8C16d14earerxvCPe_kyym09GOa8mh4qwPz8AKVKQjHsw@mail.gmail.com>
In-Reply-To: <CAMW7n8C16d14earerxvCPe_kyym09GOa8mh4qwPz8AKVKQjHsw@mail.gmail.com>
Date: Tue, 18 Mar 2025 15:52:48 +0200
Message-ID: <CAMW7n8C56acarsXA2_vGnO0K5+h_rhwYLJJDJPho5TjisWQG-A@mail.gmail.com>
Subject: Re: [PHP-DEV] PHP True Async RFC - Stage 2
To: "Rowan Tommins [IMSoP]" <imsop.php@rwec.co.uk>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="0000000000000d533806309e39d3"
From: edmond.ht@gmail.com (Edmond Dantes)

--0000000000000d533806309e39d3
Content-Type: text/plain; charset="UTF-8"

Oops, I made a mistake in the logic of `Scope` and coroutines.

According to the RFC, the following code behaves differently:

```php
currentScope()->spawn ... // This coroutine belongs to the Scope
spawn ... // This one is a child coroutine
```

I was sure that I had checked all the major edge cases. Sorry.
This will be fixed soon.

P.S. + 1 example:

<?php


declare(strict_types=1);

use Async\Scope;
use function Async\currentScope;

function fetchUrl(string $url): string {
    $ctx = stream_context_create(['http' => ['timeout' => 5]]);
    return file_get_contents($url, false, $ctx);
}

function fetchAllUrls(array $urls): array
{
    $futures = [];

    foreach ($urls as $url) {
        $futures[$url] = (spawn fetchUrl($url))->getFuture();
    }

    await currentScope();

    $results = [];

    foreach ($futures as $url => $future) {
        $results[$url] = $future->getResult();
    }

    return $results;
}

$urls = [
    'https://example.com',
    'https://php.net',
    'https://openai.com'
];

$results = await spawn fetchAllUrls($urls);
print_r($results);


---
Ed.

>

--0000000000000d533806309e39d3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Oops, I made a mistake in the logic of `Scope` and co=
routines. =C2=A0<br><br>According to the RFC, the following code behaves di=
fferently: =C2=A0<br><br>```php<br>currentScope()-&gt;spawn ... // This cor=
outine belongs to the Scope<br>spawn ... // This one is a child coroutine<b=
r></div><div>```</div><div><br></div><div>I was sure that I had checked all=
 the major edge cases. Sorry.</div><div>This will be fixed soon.=C2=A0=C2=
=A0<br></div><div><br></div><div>P.S. + 1 example:</div><div><br></div><div=
><span style=3D"color:rgb(0,51,179);font-family:&quot;JetBrains Mono&quot;,=
monospace">&lt;?php</span></div><div><div style=3D"color:rgb(8,8,8)"><pre s=
tyle=3D"font-family:&quot;JetBrains Mono&quot;,monospace"><span style=3D"co=
lor:rgb(0,51,179)"><br></span><span style=3D"color:rgb(0,51,179)">declare</=
span>(<span style=3D"color:rgb(0,0,0)">strict_types</span>=3D<span style=3D=
"color:rgb(23,80,235)">1</span>);<br><br><span style=3D"color:rgb(0,51,179)=
">use </span><span style=3D"color:rgb(128,128,128)">Async\Scope</span>;<br>=
<span style=3D"color:rgb(0,51,179)">use function </span><span style=3D"colo=
r:rgb(0,0,0)">Async</span>\<span style=3D"color:rgb(0,98,122)">currentScope=
</span>;<br><br><span style=3D"color:rgb(0,51,179)">function </span><span s=
tyle=3D"color:rgb(0,98,122)">fetchUrl</span>(<span style=3D"color:rgb(0,51,=
179)">string </span><span style=3D"color:rgb(102,0,0)">$url</span>): <span =
style=3D"color:rgb(0,51,179)">string </span>{<br>    <span style=3D"color:r=
gb(102,0,0)">$ctx </span>=3D <span style=3D"color:rgb(0,98,122)">stream_con=
text_create</span>([<span style=3D"color:rgb(6,125,23)">&#39;http&#39; </sp=
an>=3D&gt; [<span style=3D"color:rgb(6,125,23)">&#39;timeout&#39; </span>=
=3D&gt; <span style=3D"color:rgb(23,80,235)">5</span>]]);<br>    <span styl=
e=3D"color:rgb(0,51,179)">return </span><span style=3D"color:rgb(0,98,122)"=
>file_get_contents</span>(<span style=3D"color:rgb(102,0,0)">$url</span>, <=
span style=3D"color:rgb(0,51,179)">false</span>, <span style=3D"color:rgb(1=
02,0,0)">$ctx</span>);<br>}<br><br><span style=3D"color:rgb(0,51,179)">func=
tion </span><span style=3D"color:rgb(0,98,122)">fetchAllUrls</span>(<span s=
tyle=3D"color:rgb(0,51,179)">array </span><span style=3D"color:rgb(102,0,0)=
">$urls</span>): <span style=3D"color:rgb(0,51,179)">array<br></span>{<br> =
   <span style=3D"color:rgb(102,0,0)">$futures </span>=3D [];<br>    <br>  =
  <span style=3D"color:rgb(0,51,179)">foreach </span>(<span style=3D"color:=
rgb(102,0,0)">$urls </span><span style=3D"color:rgb(0,51,179)">as </span><s=
pan style=3D"color:rgb(102,0,0)">$url</span>) {<br>        <span style=3D"c=
olor:rgb(102,0,0)">$futures</span>[<span style=3D"color:rgb(102,0,0)">$url<=
/span>] =3D (<span style=3D"color:rgb(135,16,148);font-style:italic">spawn =
</span><span style=3D"color:rgb(0,98,122)">fetchUrl</span>(<span style=3D"c=
olor:rgb(102,0,0)">$url</span>))-&gt;getFuture();<br>    }<br>    <br>    <=
span style=3D"color:rgb(135,16,148);font-style:italic">await </span><span s=
tyle=3D"color:rgb(0,98,122)">currentScope</span>();<br>    <br>    <span st=
yle=3D"color:rgb(102,0,0)">$results </span>=3D [];<br>    <br>    <span sty=
le=3D"color:rgb(0,51,179)">foreach </span>(<span style=3D"color:rgb(102,0,0=
)">$futures </span><span style=3D"color:rgb(0,51,179)">as </span><span styl=
e=3D"color:rgb(102,0,0)">$url </span>=3D&gt; <span style=3D"color:rgb(102,0=
,0)">$future</span>) {<br>        <span style=3D"color:rgb(102,0,0)">$resul=
ts</span>[<span style=3D"color:rgb(102,0,0)">$url</span>] =3D <span style=
=3D"color:rgb(102,0,0)">$future</span>-&gt;<span style=3D"color:rgb(0,98,12=
2)">getResult</span>();<br>    }<br>    <br>    <span style=3D"color:rgb(0,=
51,179)">return </span><span style=3D"color:rgb(102,0,0)">$results</span>;<=
br>}<br><br><span style=3D"color:rgb(102,0,0)">$urls </span>=3D [<br>    <s=
pan style=3D"color:rgb(6,125,23)">&#39;<a href=3D"https://example.com">http=
s://example.com</a>&#39;</span>,<br>    <span style=3D"color:rgb(6,125,23)"=
>&#39;<a href=3D"https://php.net">https://php.net</a>&#39;</span>,<br>    <=
span style=3D"color:rgb(6,125,23)">&#39;<a href=3D"https://openai.com">http=
s://openai.com</a>&#39;<br></span>];<br><br><span style=3D"color:rgb(102,0,=
0)">$results </span>=3D <span style=3D"color:rgb(135,16,148);font-style:ita=
lic">await spawn </span><span style=3D"color:rgb(0,98,122)">fetchAllUrls</s=
pan>(<span style=3D"color:rgb(102,0,0)">$urls</span>);<br><span style=3D"co=
lor:rgb(0,98,122)">print_r</span>(<span style=3D"color:rgb(102,0,0)">$resul=
ts</span>);</pre></div></div><div><br></div><div>---</div><div>Ed.</div><di=
v class=3D"gmail_quote gmail_quote_container"><blockquote class=3D"gmail_qu=
ote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,20=
4);padding-left:1ex">
</blockquote></div></div>

--0000000000000d533806309e39d3--