Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126813
Precedence: bulk
MIME-Version: 1.0
References: <CAH5C8xUb1O20ZDrOQNC=ckFxHUUWSK7sw_njQQzFBd0qgQqoww@mail.gmail.com>
 <dd61999c-1ebd-4765-9add-cd8065968965@gmail.com> <CAOV5rgYZ_s1of-igLFEK7oqqh6=3HeYv0=JvvKvvjkcp0F6Q9Q@mail.gmail.com>
 <CAH5C8xV67frqOBCvLt73RM7QO86_pu40sHP5h71_kDRbKPtA8Q@mail.gmail.com>
 <1BCB4144-231D-45EA-A914-98EE8F0F503A@automattic.com> <8E614C9C-BA85-45D8-9A4E-A30D69981C5D@automattic.com>
 <CAH5C8xV69pHnSKWJrVB8EQab7vPhcaXAwYezoG6z3Oj7ZkXBaQ@mail.gmail.com>
 <bc5472e39bc607e2c7accc9d2bd6f239@bastelstu.be> <9bf11a89-39d9-457b-b0ea-789fd07d7370@gmail.com>
 <CAH5C8xWnoytE=jm1sxr-HcSZFzmG8SrzghinmBZa-QyGqN4uUg@mail.gmail.com> <6430b9ed-638d-4247-9fa9-d1a9148c382b@gmail.com>
In-Reply-To: <6430b9ed-638d-4247-9fa9-d1a9148c382b@gmail.com>
Date: Mon, 17 Mar 2025 20:58:27 +0100
Message-ID: <CAH5C8xX3tCS3B3z2YFbRudCXi=ZNHE0scrmoFO7cXxU773EfpA@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add WHATWG compliant URL parsing API
To: nyamsprod@gmail.com
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d223bf06308f367f"
From: kocsismate90@gmail.com (=?UTF-8?B?TcOhdMOpIEtvY3Npcw==?=)

--000000000000d223bf06308f367f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Ignace,

1) around `Uri\UninitializedUriException` If I look at the behaviour of
> `DatetimeImmutable` in the same scenario or a Userland object instead of
> throwing an exception an error is thrown
>
> see:
>
> - https://3v4l.org/d4VrY
> - https://3v4l.org/Wn7En
>
> Shouldn't the URI feature follow the same path for consistency ? Instead
> of throwing an exception it should throw an Error on uninitialized issue
> at least.
>

Yes, you are right! Uri\UninitializedUriException should extend an Error
indeed,
since people shouldn't try to catch it either.


>
> 2) around Normalization. In case of query normalization, sorting the
> query string is not mention does it means that with the current feature
>
> `http://example.com?foo=3Dbar&foo=3Drab` <http://example.com?foo=3Dbar&fo=
o=3Drab>
> is different from
> `http://example.com?foo=3Drab&foo=3Dbar` <http://example.com?foo=3Drab&fo=
o=3Dbar>
>
>
Yes, that's the case, this feature is not implemented. As far as I see
though, it's better
not to change the order of query parameters, especially the order of
duplicated
parameters in order not to accidentally change the intended meaning of the
query string.
What's your stance here?

M=C3=A1t=C3=A9

--000000000000d223bf06308f367f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><div>Hi I=
gnace,</div><div><br></div><blockquote class=3D"gmail_quote" style=3D"margi=
n:0px 0px 0px 0.8ex;border-left:1px solid rgb(77,77,77);padding-left:1ex">
1) around `Uri\UninitializedUriException` If I look at the behaviour of <br=
>
`DatetimeImmutable` in the same scenario or a Userland object instead of <b=
r>
throwing an exception an error is thrown<br>
<br>
see:<br>
<br>
- <a href=3D"https://3v4l.org/d4VrY" rel=3D"noreferrer" target=3D"_blank">h=
ttps://3v4l.org/d4VrY</a><br>
- <a href=3D"https://3v4l.org/Wn7En" rel=3D"noreferrer" target=3D"_blank">h=
ttps://3v4l.org/Wn7En</a><br>
<br>
Shouldn&#39;t the URI feature follow the same path for consistency ? Instea=
d <br>
of throwing an exception it should throw an Error on uninitialized issue<br=
>
at least.<br></blockquote><div><br></div><div>Yes, you are right!=C2=A0<spa=
n style=3D"color:rgb(191,191,191)">Uri\UninitializedUriException should ext=
end an Error indeed,</span></div><div><span style=3D"color:rgb(191,191,191)=
">since people shouldn&#39;t try to catch it either.</span></div><div>=C2=
=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e=
x;border-left:1px solid rgb(77,77,77);padding-left:1ex">
<br>
2) around Normalization. In case of query normalization, sorting the <br>
query string is not mention does it means that with the current feature<br>
<br>
`<a href=3D"http://example.com?foo=3Dbar&amp;foo=3Drab" rel=3D"noreferrer" =
target=3D"_blank">http://example.com?foo=3Dbar&amp;foo=3Drab`</a><br>
is different from<br>
`<a href=3D"http://example.com?foo=3Drab&amp;foo=3Dbar" rel=3D"noreferrer" =
target=3D"_blank">http://example.com?foo=3Drab&amp;foo=3Dbar`</a><br><br></=
blockquote><div><br></div><div>Yes, that&#39;s the case, this feature is no=
t implemented. As far as I see though, it&#39;s better</div><div><span styl=
e=3D"color:rgb(191,191,191)">not to change=C2=A0</span><span style=3D"color=
:rgb(191,191,191)">the order of query parameters, especially the order of d=
uplicated</span></div><div><span style=3D"color:rgb(191,191,191)">parameter=
s in order not to accidentally change the intended meaning of the query str=
ing</span><span style=3D"color:rgb(191,191,191)">.</span></div><div><span s=
tyle=3D"color:rgb(191,191,191)">What&#39;s your stance here?</span></div><d=
iv><br></div><div><span style=3D"color:rgb(191,191,191)">M=C3=A1t=C3=A9</sp=
an></div><div><br></div><div>=C2=A0</div></div></div>

--000000000000d223bf06308f367f--