Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126712
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\))
Subject: Re: [PHP-DEV] Consensus on argument validation for built-in functions
Date: Tue, 11 Mar 2025 10:07:50 +0100
References: <CAPTD5yHhpcJJDNWMCpQSrkGyY5+YtgKUy1OKYv5t03KyzoAXbA@mail.gmail.com>
 <XOTiGCaoOV5bvCQP2nMZW7AzIoOdH5la7sgmJ8KK51Z6n9zJLiAM7cYTiUhH5zsrrMbMUZe257bmPe8SgcNgN2IqNzPUty68egntFngnsXU=@gpb.moe>
To: PHP internals <internals@lists.php.net>
In-Reply-To: <XOTiGCaoOV5bvCQP2nMZW7AzIoOdH5la7sgmJ8KK51Z6n9zJLiAM7cYTiUhH5zsrrMbMUZe257bmPe8SgcNgN2IqNzPUty68egntFngnsXU=@gpb.moe>
Message-ID: <C3E24D9F-3D72-401F-81A9-CAA245308703@cschneid.com>
From: cschneid@cschneid.com (Christian Schneider)

Am 11.03.2025 um 07:32 schrieb Gina P. Banyard <internals@gpb.moe>:
> On Monday, 10 March 2025 at 23:07, Jorg Sowa <jorg.sowa@gmail.com> =
wrote:
>> I=E2=80=99d like to align on the approach to validating arguments for =
built-in functions (usually for flag inputs). Some ongoing discussions =
in PRs:
>> - https://github.com/php/php-src/pull/15647
>=20
> My opinion on this topic is well known, validation errors should go =
straight to a ValueError.
> And if not a ValueError then it should be an E_WARNING.
> Raising a deprecation is frankly non-sensical.

I'll sound a bit like a broken record :-)

The very first example shows why we should have an E_WARNING phase to =
smoothen BC changes:
Code like
	$a =3D array_filter(["a", "", "b"], strlen(...), 666);
which currently ignores the bogus value and allows the code to continue =
would suddenly stop with en Exception.

Fixing the code is trivial and a warning helps identify those code =
locations but decoupling the moment of upgrading PHP from having to fix =
all code is IMHO still valuable. Especially when using third-party =
packages which might have a delay in fixing it.
I'm still waiting on some packages to fix new warnings for PHP 8.4 even =
though we've upgraded to the new version already.

Conclusion:
Yes, I'd very much like the 1) warning 2) ValueError approach from the =
original mail to be the default.

Regards,
- Chris