Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126704
Precedence: bulk
MIME-Version: 1.0
References: <CAH5C8xUb1O20ZDrOQNC=ckFxHUUWSK7sw_njQQzFBd0qgQqoww@mail.gmail.com>
 <dd61999c-1ebd-4765-9add-cd8065968965@gmail.com> <CAOV5rgYZ_s1of-igLFEK7oqqh6=3HeYv0=JvvKvvjkcp0F6Q9Q@mail.gmail.com>
 <CAH5C8xV67frqOBCvLt73RM7QO86_pu40sHP5h71_kDRbKPtA8Q@mail.gmail.com>
 <1BCB4144-231D-45EA-A914-98EE8F0F503A@automattic.com> <8E614C9C-BA85-45D8-9A4E-A30D69981C5D@automattic.com>
 <CAH5C8xV69pHnSKWJrVB8EQab7vPhcaXAwYezoG6z3Oj7ZkXBaQ@mail.gmail.com>
 <bc5472e39bc607e2c7accc9d2bd6f239@bastelstu.be> <f2cac348d056aeaf44bfa3233e6f9c3c@bastelstu.be>
 <015e01db861b$09afb270$1d0f1750$@glaive.pro> <790c93f954ccd71b361da9556ae2a383@bastelstu.be>
In-Reply-To: <790c93f954ccd71b361da9556ae2a383@bastelstu.be>
Date: Mon, 10 Mar 2025 23:58:16 +0100
Message-ID: <CAH5C8xXRjvV9q-YF3pwtVp=5QPR2+XB30vWAUgq+LmtYpJOdsg@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add WHATWG compliant URL parsing API
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: Juris Evertovskis <juris@glaive.pro>, Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000fa9035063004e867"
From: kocsismate90@gmail.com (=?UTF-8?B?TcOhdMOpIEtvY3Npcw==?=)

--000000000000fa9035063004e867
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Juris and Tim,


> Am 2025-02-23 18:47, schrieb Juris Evertovskis:
> > As those are URI validation errors, maybe something like
> > `Uri\WhatWg\ValidationError` would be both less clashy and less
> > redundant?
>
> I like that suggestion.
>
> Best regards
> Tim D=C3=BCsterhus
>

I liked it as well, so I changed the related classes the following way:

- Uri\WhatWg\WhatWgError became Uri\WhatWg\UrlValidationError
- Uri\WhatWg\WhatWgErrorType became Uri\WhatWg\UrlValidationErrorType

This way, WhatWg is not duplicated in the FQCN, but the class name is still
specific enough to possibly not clash with anything else.
I could also imagine removing the Url prefix, but I like it, since it
highlights that it's related to WHATWG URLs.

Regards,
M=C3=A1t=C3=A9

--000000000000fa9035063004e867
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><div>Hi J=
uris and Tim,</div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(77,77,77);padding-le=
ft:1ex">
Am 2025-02-23 18:47, schrieb Juris Evertovskis:<br>
&gt; As those are URI validation errors, maybe something like<br>
&gt; `Uri\WhatWg\ValidationError` would be both less clashy and less <br>
&gt; redundant?<br>
<br>
I like that suggestion.<br>
<br>
Best regards<br>
Tim D=C3=BCsterhus<br></blockquote><div><br></div><div>I liked it as well, =
so I changed the related classes the following way:</div><div><br></div><di=
v><span style=3D"color:rgb(191,191,191)">-=C2=A0</span><span style=3D"color=
:rgb(191,191,191)">Uri\WhatWg\WhatWgError=C2=A0</span><span style=3D"color:=
rgb(191,191,191)">became Uri\WhatWg\UrlValidationError</span></div><div>-=
=C2=A0<span style=3D"color:rgb(191,191,191)">Uri\WhatWg\WhatWgErrorType=C2=
=A0</span><span style=3D"color:rgb(191,191,191)">became Uri\WhatWg\UrlValid=
ationErrorType</span></div><div><span style=3D"color:rgb(191,191,191)"><br>=
</span></div><div><span style=3D"color:rgb(191,191,191)">This way, WhatWg i=
s not duplicated=C2=A0in the FQCN, but the class name is still specific eno=
ugh to possibly not clash with anything else.</span></div><div><span style=
=3D"color:rgb(191,191,191)">I could also imagine removing the Url prefix, b=
ut I like it, since it highlights that it&#39;s related to WHATWG URLs.</sp=
an></div><div><span style=3D"color:rgb(191,191,191)"><br></span></div><div>=
<span style=3D"color:rgb(191,191,191)">Regards,</span></div><div><span styl=
e=3D"color:rgb(191,191,191)">M=C3=A1t=C3=A9</span></div><div><br></div></di=
v></div>

--000000000000fa9035063004e867--