Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126607
Message-ID: <8303823b-a193-411f-bb60-c0221e7f29dc@bastelstu.be>
Date: Thu, 6 Mar 2025 22:00:42 +0100
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] RFC: short and inner classes
To: Niels Dossche <dossche.niels@gmail.com>, internals@lists.php.net
References: <aae32397-0567-417f-adbe-6b663d5c49ae@app.fastmail.com>
 <f9667ab8-ce63-4ad2-bed1-c5829629a200@gmail.com>
Content-Language: en-US
In-Reply-To: <f9667ab8-ce63-4ad2-bed1-c5829629a200@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 3/6/25 20:08, Niels Dossche wrote:
> What I'm less in favor of is the implementation choice to expose the inner class as a property/const and using a fetch mode to grab it.
> That feels quite weird to me honestly. How did you arrive at this choice?

Somewhat relatedly, the RFC does not mention how the choice of `::` as 
the separator interacts with the following features (i.e. what will the 
result of each of the statements be):

     Closure::fromCallable('Outer::Inner::method');
     new ReflectionMethod('Outer::Inner::method');
     defined('Outer::Inner');
     constant('Outer::Inner');
     $inner = 'Inner';
     Outer::{$inner};

… and any other meta-programming functionality working on class 
constants or static methods.

Also, what will happen for:

     class P {
         class Inner { }
     }

     class C extends P {
          const Inner = 'x';
     }

(and vice versa)

Best regards
Tim Düsterhus