Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126595
Precedence: bulk
MIME-Version: 1.0
Date: Thu, 06 Mar 2025 09:04:55 +0100
To: Rob Landers <rob@bottled.codes>
Cc: Juris Evertovskis <juris@glaive.pro>, internals@lists.php.net
Subject: Re: [PHP-DEV] RFC: short and inner classes
In-Reply-To: <ac0f8436-a960-4866-a5f6-f4c9a0e81589@app.fastmail.com>
References: <aae32397-0567-417f-adbe-6b663d5c49ae@app.fastmail.com>
 <076001db8e34$41cab990$c5602cb0$@glaive.pro>
 <ac0f8436-a960-4866-a5f6-f4c9a0e81589@app.fastmail.com>
Message-ID: <e306edc4a1678cd62e4b960e98f56689@bastelstu.be>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

Am 2025-03-06 07:23, schrieb Rob Landers:
> So, technically, they aren’t required to be in the same RFC; but also, 
> they complement each other very well.

They really should be separate RFCs then. Your RFC text acknowledges 
that in the very first sentence: “two significant enhancements to the 
language”. Each individual proposal likely has sufficient bike-shedding 
potential on its own and discussion will likely get messy, because one 
needs to closely follow which of the two proposals an argument relates 
to.

---------

I've also given your RFC a first pass, without yet trying to understand 
all the implications. Here's some comments.

As for the “Short classes” proposal:

- I don't understand the use of `private` properties. Given that the 
classes cannot have methods, they would be inaccessible, no?

As for the “Inner classes” proposal:

- “abstract is not allowed as an inner class cannot be parent classes.” 
- Why?
- “type hint” - PHP does not have type hints, types are enforced. You 
mean “Type declaration”.
- “this allows you to redefine an inner class in a subclass, allowing 
rich hierarchies” - The RFC does not specify if and how this interacts 
with the LSP checks.

Best regards
Tim Düsterhus