Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126577
Precedence: bulk
MIME-Version: 1.0
References: <CA+XhMqxtmSEepp1oDj4B_P_x5Nn9ft_3yiUkEdEzy4sKh4KCHQ@mail.gmail.com>
 <CAEKnhAFe96EjF2KgqFMBTLX_jfkKR2JQqmSS-E2iMO2pgbnMzw@mail.gmail.com>
 <gay9WuIwYkvc3VrnorXcewmf6-JfWHlzAh5CFa3_tauZgRn0PSaXh2YeVel7Ek6ZKh-tu1JdkoULLs3NdHjd2g4JQKXPZ_ezfRulrMqP5xU=@gpb.moe>
 <10f99b41-4124-485f-ac64-1df1498c8a43@bastelstu.be>
In-Reply-To: <10f99b41-4124-485f-ac64-1df1498c8a43@bastelstu.be>
Date: Wed, 5 Mar 2025 12:11:30 +0000
Message-ID: <CA+XhMqxyrHMNkdm5VLHgK0Wo0kiJttjr31XbBuKF68pkBY0hBg@mail.gmail.com>
Subject: Re: [PHP-DEV] PHP socket ethernet support - step 2
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: "Gina P. Banyard" <internals@gpb.moe>, Jakub Zelenka <bukka@php.net>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d4f90c062f974a75"
From: devnexen@gmail.com (David CARLIER)

--000000000000d4f90c062f974a75
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 4 Mar 2025 at 22:34, Tim D=C3=BCsterhus <tim@bastelstu.be> wrote:

> Hi
>
> On 3/4/25 23:18, Gina P. Banyard wrote:
> > Those two classes predate the Namespaces in bundled PHP extensions [1]
> RFC, I do think adding a namespace is better.
> > And we could also move the two classes into the new namespace and add
> class aliases for the global ones, considering they are quite recent
> additions to PHP.
>
> I agree that adding a namespace would be appropriate here. Looking at
> the sockets.stub.php, it pollutes the global namespace quite a bit. I
> probably miscounted, but it appears to be at least 10 different prefixes
> for the global constants.
>

Ok I ll go the namespace route then, fair point.

>
> It would probably be in order to also alias all the constants into the
> namespace (possibly converting them to enums where appropriate) and then
> in a follow-up version deprecate the global ones. I think that would
> bring quite a bit of positive impact, for minimal effort.
>
> --------
>
> As for the classes themselves: It does not appear to be defined in our
> naming policy [1], but the properties should likely use camel-case, as
> that is the established convention for userland code. And I'm also
> curious why the port properties are strings, not ints?

Yes it is a definition mistake it means to be a int indeed.


> And what is the
> payload object, is that just stdClass?
>

 Not really it's supposed to be one of the new classes.

>
> Best regards
> Tim D=C3=BCsterhus
>
> [1]
> https://github.com/php/policies/blob/main/coding-standards-and-naming.rst
>

--000000000000d4f90c062f974a75
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, 4 Mar 2=
025 at 22:34, Tim D=C3=BCsterhus &lt;<a href=3D"mailto:tim@bastelstu.be">ti=
m@bastelstu.be</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" st=
yle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padd=
ing-left:1ex">Hi<br>
<br>
On 3/4/25 23:18, Gina P. Banyard wrote:<br>
&gt; Those two classes predate the Namespaces in bundled PHP extensions [1]=
 RFC, I do think adding a namespace is better.<br>
&gt; And we could also move the two classes into the new namespace and add =
class aliases for the global ones, considering they are quite recent additi=
ons to PHP.<br>
<br>
I agree that adding a namespace would be appropriate here. Looking at <br>
the sockets.stub.php, it pollutes the global namespace quite a bit. I <br>
probably miscounted, but it appears to be at least 10 different prefixes <b=
r>
for the global constants.<br></blockquote><div><br></div><div>Ok I ll go th=
e namespace route then, fair point.=C2=A0</div><blockquote class=3D"gmail_q=
uote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,2=
04);padding-left:1ex">
<br>
It would probably be in order to also alias all the constants into the <br>
namespace (possibly converting them to enums where appropriate) and then <b=
r>
in a follow-up version deprecate the global ones. I think that would <br>
bring quite a bit of positive impact, for minimal effort.<br>
<br>
--------<br>
<br>
As for the classes themselves: It does not appear to be defined in our <br>
naming policy [1], but the properties should likely use camel-case, as <br>
that is the established convention for userland code. And I&#39;m also <br>
curious why the port properties are strings, not ints? </blockquote><div>Ye=
s it is a definition mistake it means to be a int indeed.</div><div>=C2=A0<=
/div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bo=
rder-left:1px solid rgb(204,204,204);padding-left:1ex">And what is the <br>
payload object, is that just stdClass?<br></blockquote><div><br></div><div>=
=C2=A0Not really it&#39;s supposed to be one of the new classes.</div><bloc=
kquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:=
1px solid rgb(204,204,204);padding-left:1ex">
<br>
Best regards<br>
Tim D=C3=BCsterhus<br>
<br>
[1] <br>
<a href=3D"https://github.com/php/policies/blob/main/coding-standards-and-n=
aming.rst" rel=3D"noreferrer" target=3D"_blank">https://github.com/php/poli=
cies/blob/main/coding-standards-and-naming.rst</a><br>
</blockquote></div></div>

--000000000000d4f90c062f974a75--