Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126568
Message-ID: <10f99b41-4124-485f-ac64-1df1498c8a43@bastelstu.be>
Date: Tue, 4 Mar 2025 23:34:10 +0100
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] PHP socket ethernet support - step 2
To: "Gina P. Banyard" <internals@gpb.moe>, Jakub Zelenka <bukka@php.net>
Cc: David CARLIER <devnexen@gmail.com>,
 PHP internals <internals@lists.php.net>
References: <CA+XhMqxtmSEepp1oDj4B_P_x5Nn9ft_3yiUkEdEzy4sKh4KCHQ@mail.gmail.com>
 <CAEKnhAFe96EjF2KgqFMBTLX_jfkKR2JQqmSS-E2iMO2pgbnMzw@mail.gmail.com>
 <gay9WuIwYkvc3VrnorXcewmf6-JfWHlzAh5CFa3_tauZgRn0PSaXh2YeVel7Ek6ZKh-tu1JdkoULLs3NdHjd2g4JQKXPZ_ezfRulrMqP5xU=@gpb.moe>
Content-Language: en-US
In-Reply-To: <gay9WuIwYkvc3VrnorXcewmf6-JfWHlzAh5CFa3_tauZgRn0PSaXh2YeVel7Ek6ZKh-tu1JdkoULLs3NdHjd2g4JQKXPZ_ezfRulrMqP5xU=@gpb.moe>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 3/4/25 23:18, Gina P. Banyard wrote:
> Those two classes predate the Namespaces in bundled PHP extensions [1] RFC, I do think adding a namespace is better.
> And we could also move the two classes into the new namespace and add class aliases for the global ones, considering they are quite recent additions to PHP.

I agree that adding a namespace would be appropriate here. Looking at 
the sockets.stub.php, it pollutes the global namespace quite a bit. I 
probably miscounted, but it appears to be at least 10 different prefixes 
for the global constants.

It would probably be in order to also alias all the constants into the 
namespace (possibly converting them to enums where appropriate) and then 
in a follow-up version deprecate the global ones. I think that would 
bring quite a bit of positive impact, for minimal effort.

--------

As for the classes themselves: It does not appear to be defined in our 
naming policy [1], but the properties should likely use camel-case, as 
that is the established convention for userland code. And I'm also 
curious why the port properties are strings, not ints? And what is the 
payload object, is that just stdClass?

Best regards
Tim Düsterhus

[1] 
https://github.com/php/policies/blob/main/coding-standards-and-naming.rst