Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126560
Precedence: bulk
MIME-Version: 1.0
References: <CA+XhMqxtmSEepp1oDj4B_P_x5Nn9ft_3yiUkEdEzy4sKh4KCHQ@mail.gmail.com>
 <CAEKnhAFe96EjF2KgqFMBTLX_jfkKR2JQqmSS-E2iMO2pgbnMzw@mail.gmail.com>
In-Reply-To: <CAEKnhAFe96EjF2KgqFMBTLX_jfkKR2JQqmSS-E2iMO2pgbnMzw@mail.gmail.com>
Date: Tue, 4 Mar 2025 18:00:40 +0000
Message-ID: <CA+XhMqx34hVX+dE_AbuWA9RAkGrR_r5iYE7Bn1xrOhYZMG-L-A@mail.gmail.com>
Subject: Re: [PHP-DEV] PHP socket ethernet support - step 2
To: Jakub Zelenka <bukka@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ae0acc062f880d60"
From: devnexen@gmail.com (David CARLIER)

--000000000000ae0acc062f880d60
Content-Type: text/plain; charset="UTF-8"

On Mon, 3 Mar 2025 at 21:21, Jakub Zelenka <bukka@php.net> wrote:

> Hi,
>
>
>> I am working on the second pass of this feature and write here because of
>> the legitimate concern regarding new classes to add.
>>
>> PR here <https://github.com/php/php-src/pull/17926>
>>
>
> For those that want to quickly see the actually classes, here is a stub
> link:
> https://github.com/php/php-src/pull/17926/files#diff-190e64a9475f39f2b575e6032d6539b504b33fe534965e5bb3512fe430fe1846
>
>
>
>> I agree also on adding a namespace on top (Sockets ?) and changing the
>> class names.
>>
>
> I think it would be good to note that there are already two classes
> defined in socket extension:
>
> final class Socket
> {
> }
>
> final class AddressInfo
> {
> }
>
> So it might look a bit strange if those two are not namespaced and the new
> ones are. The AddressInfo is a bit unfortunate name though. The namespace
> seems cleaner but not sure if prefix would be more consistent. Although
> having SocketPacket is not exactly nice so probably Socket\Packet is
> better. But I don't really mind. I would just really prefer to not
> introduce those classes without namespace or prefix.
>

ACK Sure fair point ; in practice prefixing seems the least disruptive
change.

>
> Regards
>
> Jakub
>

--000000000000ae0acc062f880d60
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=
=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, 3 Mar 2025 a=
t 21:21, Jakub Zelenka &lt;<a href=3D"mailto:bukka@php.net" target=3D"_blan=
k">bukka@php.net</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" =
style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pa=
dding-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_quote"><div>Hi,</div><=
div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0=
px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=
=3D"ltr"><div></div><div>I am working on the second pass of this feature an=
d write here because of the legitimate concern regarding new classes to add=
.</div><div><br></div><div><a href=3D"https://github.com/php/php-src/pull/1=
7926" target=3D"_blank">PR here</a></div></div></blockquote><div><br></div>=
<div>For those that want to quickly see the actually classes, here is a stu=
b link:=C2=A0<a href=3D"https://github.com/php/php-src/pull/17926/files#dif=
f-190e64a9475f39f2b575e6032d6539b504b33fe534965e5bb3512fe430fe1846" target=
=3D"_blank">https://github.com/php/php-src/pull/17926/files#diff-190e64a947=
5f39f2b575e6032d6539b504b33fe534965e5bb3512fe430fe1846</a>=C2=A0</div><div>=
=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0=
.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"l=
tr"><div>I agree also on adding a namespace on top (Sockets ?) and changing=
 the class names.</div></div></blockquote><div><br></div><div>I think it wo=
uld be good to note that there are already two classes defined in socket ex=
tension:</div><div><br></div>final class Socket<br>{<br>}<br><br>final clas=
s AddressInfo<br>{<br><div>}=C2=A0</div><div><br></div><div>So it might loo=
k a bit strange if those two are not namespaced and the new ones are. The A=
ddressInfo is a bit unfortunate name though. The namespace seems cleaner bu=
t not sure if prefix would be more consistent. Although having SocketPacket=
 is not exactly nice so probably Socket\Packet is better. But I don&#39;t r=
eally mind. I would just really prefer to not introduce those classes witho=
ut namespace or prefix.</div></div></div></blockquote><div><br></div><div>A=
CK Sure fair point ; in practice prefixing seems the least disruptive chang=
e.</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex=
;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">=
<div class=3D"gmail_quote"><div><br></div><div>Regards</div><div><br></div>=
<div>Jakub</div></div></div>
</blockquote></div></div>
</div>

--000000000000ae0acc062f880d60--