Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126559
Precedence: bulk
MIME-Version: 1.0
References: <CA+XhMqxtmSEepp1oDj4B_P_x5Nn9ft_3yiUkEdEzy4sKh4KCHQ@mail.gmail.com>
In-Reply-To: <CA+XhMqxtmSEepp1oDj4B_P_x5Nn9ft_3yiUkEdEzy4sKh4KCHQ@mail.gmail.com>
Date: Mon, 3 Mar 2025 22:20:50 +0100
Message-ID: <CAEKnhAFe96EjF2KgqFMBTLX_jfkKR2JQqmSS-E2iMO2pgbnMzw@mail.gmail.com>
Subject: Re: [PHP-DEV] PHP socket ethernet support - step 2
To: David CARLIER <devnexen@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000b2791d062f76bb4d"
From: bukka@php.net (Jakub Zelenka)

--000000000000b2791d062f76bb4d
Content-Type: text/plain; charset="UTF-8"

Hi,


> I am working on the second pass of this feature and write here because of
> the legitimate concern regarding new classes to add.
>
> PR here <https://github.com/php/php-src/pull/17926>
>

For those that want to quickly see the actually classes, here is a stub
link:
https://github.com/php/php-src/pull/17926/files#diff-190e64a9475f39f2b575e6032d6539b504b33fe534965e5bb3512fe430fe1846



> I agree also on adding a namespace on top (Sockets ?) and changing the
> class names.
>

I think it would be good to note that there are already two classes defined
in socket extension:

final class Socket
{
}

final class AddressInfo
{
}

So it might look a bit strange if those two are not namespaced and the new
ones are. The AddressInfo is a bit unfortunate name though. The namespace
seems cleaner but not sure if prefix would be more consistent. Although
having SocketPacket is not exactly nice so probably Socket\Packet is
better. But I don't really mind. I would just really prefer to not
introduce those classes without namespace or prefix.

Regards

Jakub

--000000000000b2791d062f76bb4d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><div>Hi,<=
/div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px=
 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><di=
v dir=3D"ltr"><div></div><div>I am working on the second pass of this featu=
re and write here because of the legitimate concern regarding new classes t=
o add.</div><div><br></div><div><a href=3D"https://github.com/php/php-src/p=
ull/17926" target=3D"_blank">PR here</a></div></div></blockquote><div><br><=
/div><div>For those that want to quickly see the actually classes, here is =
a stub link:=C2=A0<a href=3D"https://github.com/php/php-src/pull/17926/file=
s#diff-190e64a9475f39f2b575e6032d6539b504b33fe534965e5bb3512fe430fe1846">ht=
tps://github.com/php/php-src/pull/17926/files#diff-190e64a9475f39f2b575e603=
2d6539b504b33fe534965e5bb3512fe430fe1846</a>=C2=A0</div><div>=C2=A0</div><b=
lockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-le=
ft:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div>I agr=
ee also on adding a namespace on top (Sockets ?) and changing the class nam=
es.</div></div></blockquote><div><br></div><div>I think it would be good to=
 note that there are already two classes defined in socket extension:</div>=
<div><br></div>final class Socket<br>{<br>}<br><br>final class AddressInfo<=
br>{<br><div>}=C2=A0</div><div><br></div><div>So it might look a bit strang=
e if those two are not namespaced and the new ones are. The AddressInfo is =
a bit unfortunate name though. The namespace seems cleaner but not sure if =
prefix would be more consistent. Although having SocketPacket is not exactl=
y nice so probably Socket\Packet is better. But I don&#39;t really mind. I =
would just really prefer to not introduce those classes without namespace o=
r prefix.</div><div><br></div><div>Regards</div><div><br></div><div>Jakub</=
div></div></div>

--000000000000b2791d062f76bb4d--