Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126522
Precedence: bulk
MIME-Version: 1.0
Date: Fri, 28 Feb 2025 10:33:02 +0200
Message-ID: <CADt6OBPxRkRTbSF_=Tf_ykTU8dGeKTJsEEZUF1-+tRpDOt8hLA@mail.gmail.com>
Subject: [PHP-DEV] Enums should implement Stringable interface by default
To: internals@lists.php.net
Content-Type: multipart/alternative; boundary="00000000000043f13f062f2fa8ed"
From: janis.kajaks@gmail.com (Janis Kajaks)

--00000000000043f13f062f2fa8ed
Content-Type: text/plain; charset="UTF-8"

 Hi,
I'm writing this email with a reference to https://wiki.php.net/rfc/howto.
My suggestion is that all enums (both basic/pure and backed) should
implement Stringable interface by default, and before you say that it's
totally wrong or impossible let me explain why.
Let's say I have a backed enum:

enum Suit: string {
  case Hearts = 'H';
  case Diamonds = 'D';
  case Clubs = 'C';
  case Spades = 'S';}

Now if I'm trying something like this "echo Suit::Hearts;"I will get an
error "Fatal error: Uncaught Error: Object of class Suit could not be
converted to string"
BUT if I'm trying to use this enum as a part DTO (data transfer object) and
then serialize it or do something as simple as "echo
json_encode(Suit::Hearts);" then suddenly PHP knows how to convert enum to
string. This feels so unfair to me that I finally decided to write this
email.
The same applies to basic enums which have only case names, but they are
still stringable as $enum->name.

Please give me the initial feedback to understand if it's worth proceeding
with a RFC or not.


Best regards,
Janis Kajaks

--00000000000043f13f062f2fa8ed
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">
<div dir=3D"ltr"><div>Hi,</div><div>I&#39;m writing this email with a refer=
ence to <a href=3D"https://wiki.php.net/rfc/howto" target=3D"_blank">https:=
//wiki.php.net/rfc/howto</a>.</div><div>My
 suggestion is that all enums (both basic/pure and backed) should=20
implement Stringable interface by default, and before you say that it&#39;s=
=20
totally wrong or impossible let me explain why.</div><div>Let&#39;s say I h=
ave a backed enum:</div>
<pre>enum Suit<span>:</span> string <span>{</span>
  <span>case</span> Hearts <span>=3D</span> <span>&#39;H&#39;</span><span>;=
</span>
  <span>case</span> Diamonds <span>=3D</span> <span>&#39;D&#39;</span><span=
>;</span>
  <span>case</span> Clubs <span>=3D</span> <span>&#39;C&#39;</span><span>;<=
/span>
  <span>case</span> Spades <span>=3D</span> <span>&#39;S&#39;</span><span>;=
</span>
<span>}</span><br><br></pre><div>Now if I&#39;m trying something like this=
=20
&quot;echo Suit::Hearts;&quot;I will get an error &quot;Fatal error: Uncaug=
ht Error:=20
Object of class Suit could not be converted to string&quot;</div><div>BUT i=
f=20
I&#39;m trying to use this enum as a part DTO (data transfer object) and=20
then serialize it or do something as simple as &quot;echo=20
json_encode(Suit::Hearts);&quot; then suddenly PHP knows how to convert enu=
m=20
to string. This feels so unfair to me that I finally decided to write=20
this email.<br></div><div>The same applies to basic enums which have only c=
ase names, but they are still stringable as $enum-&gt;name.</div><div><br><=
/div><div>Please give me the initial feedback to understand if it&#39;s wor=
th proceeding with a RFC or not.</div><div><br></div><div><br></div><div>Be=
st regards,</div><div>Janis Kajaks</div></div>

</div>

--00000000000043f13f062f2fa8ed--