Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126498
Precedence: bulk
MIME-Version: 1.0
Date: Mon, 24 Feb 2025 17:22:39 +0100
To: Hammed Ajao <hamiegold@gmail.com>
Cc: "Gina P. Banyard" <internals@gpb.moe>, Nicolas Grekas
 <nicolas.grekas+php@gmail.com>, internals@lists.php.net
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add WHATWG compliant URL parsing API
In-Reply-To: <CA+JpajnwHWurb7juiErN5xP9cUt2EKfLigdO+XoDujP7JbzJqA@mail.gmail.com>
References: <CAH5C8xUb1O20ZDrOQNC=ckFxHUUWSK7sw_njQQzFBd0qgQqoww@mail.gmail.com>
 <CAH5C8xV67frqOBCvLt73RM7QO86_pu40sHP5h71_kDRbKPtA8Q@mail.gmail.com>
 <1BCB4144-231D-45EA-A914-98EE8F0F503A@automattic.com>
 <8E614C9C-BA85-45D8-9A4E-A30D69981C5D@automattic.com>
 <CAH5C8xV69pHnSKWJrVB8EQab7vPhcaXAwYezoG6z3Oj7ZkXBaQ@mail.gmail.com>
 <bc5472e39bc607e2c7accc9d2bd6f239@bastelstu.be>
 <9bf11a89-39d9-457b-b0ea-789fd07d7370@gmail.com>
 <af6314918964afe648c497fd9d9b7bd8@bastelstu.be>
 <CAOWwgpk=V=wg3OZC2nx_MNpU652XH7e30+x8y3fCsvTR6z_Etw@mail.gmail.com>
 <yYd34XnAc72nrzGrmQk4AhyzgvYeN6wKVp9B8eDRUBYjYKm-oaxsiFlQ2Z1wzL9ttWxYp4lROeoK2rEiBlTerKi5zst-posN8NVhnWE5-Ss=@gpb.moe>
 <CA+JpajnwHWurb7juiErN5xP9cUt2EKfLigdO+XoDujP7JbzJqA@mail.gmail.com>
Message-ID: <e595088caae06cbee6449a421c959380@bastelstu.be>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

Am 2025-02-24 15:05, schrieb Hammed Ajao:
> What's wrong with declaring all the methods as final eg.
> https://github.com/lnear-dev/ada-url/blob/main/ada_url.stub.php

It is not possible to construct a subclass in a generic fashion, because 
you don't know the constructor’s signature and you also don’t know if it 
added some properties with a certain semantic. That means that the 
`with*()`ers are unable to return an instance of the subclass, leading 
to confusing behavior in cases like these:

     final class HttpUrl extends \Uri\Rfc3986\Uri {
         public function __construct(string $uri, public readonly bool 
$allowInsecure) {
             parent::__construct($uri);

             if ($this->getScheme() !== 'https') {
                 if ($allowInsecure) {
                    if ($this->getScheme() !== 'http') {
                        throw new ValueError('Scheme must be https or 
http');
                    }
                 } else {
                     throw new ValueError('Scheme must be https');
                 }
             }
         }
     }

     $httpUrl = (new HttpUrl('https://example.com'))->withPath('/foo');
     get_class($httpUrl); // \Uri\Rfc3986\Uri

Best regards
Tim Düsterhus