Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126479
Precedence: bulk
MIME-Version: 1.0
Date: Sun, 23 Feb 2025 16:05:25 +0100
To: =?UTF-8?Q?M=C3=A1t=C3=A9_Kocsis?= <kocsismate90@gmail.com>
Cc: Internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add WHATWG compliant URL parsing API
In-Reply-To: <bc5472e39bc607e2c7accc9d2bd6f239@bastelstu.be>
References: <CAH5C8xUb1O20ZDrOQNC=ckFxHUUWSK7sw_njQQzFBd0qgQqoww@mail.gmail.com>
 <dd61999c-1ebd-4765-9add-cd8065968965@gmail.com>
 <CAOV5rgYZ_s1of-igLFEK7oqqh6=3HeYv0=JvvKvvjkcp0F6Q9Q@mail.gmail.com>
 <CAH5C8xV67frqOBCvLt73RM7QO86_pu40sHP5h71_kDRbKPtA8Q@mail.gmail.com>
 <1BCB4144-231D-45EA-A914-98EE8F0F503A@automattic.com>
 <8E614C9C-BA85-45D8-9A4E-A30D69981C5D@automattic.com>
 <CAH5C8xV69pHnSKWJrVB8EQab7vPhcaXAwYezoG6z3Oj7ZkXBaQ@mail.gmail.com>
 <bc5472e39bc607e2c7accc9d2bd6f239@bastelstu.be>
Message-ID: <f2cac348d056aeaf44bfa3233e6f9c3c@bastelstu.be>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

[dropping Dennis from the Cc list]

Am 2025-02-21 13:06, schrieb Tim Düsterhus:
> We already had extensive off-list discussion about the RFC and I agree 
> it's in a good shape now. I've given it another read and here's my 
> remarks:

One more thing that came to my mind, but where I'm not sure what the 
correct choice is:

Naming of `WhatWgError` and `WhatWgErrorType`. They are placed within 
the `Uri\WhatWg` namespace, making the `WhatWg` in their name a little 
redundant.

For Exceptions the recommendation is to use this kind of redundant 
naming, to make implicit imports for catch blocks more convenient 
compared to needing to alias each and every `Exception` class. The same 
reasoning *could* also apply here, but here I find it less obvious.

The alternative would probably be `Uri\WhatWg\Error` and 
`Uri\WhatWg\Error\Type`.

No strong opinion from my side, but wanted to mention it nevertheless.

Best regards
Tim Düsterhus