Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126460
Precedence: bulk
MIME-Version: 1.0 (Mimestream 1.5.0)
References: <528e16e1-1fb3-448a-b187-7cc84e1bcc4a@seld.be>
In-Reply-To: <528e16e1-1fb3-448a-b187-7cc84e1bcc4a@seld.be>
Date: Tue, 18 Feb 2025 12:38:35 -0800
Message-ID: <CAEPJdunFxGNxPXk3g6XZ_Kyj9dRxTDfKJh9MukDG=i2ox1vuKQ@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Modern Compression (zstd, brotli)
To: Jordi Boggiano <j.boggiano@seld.be>
Cc: Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000008df54062e70a0d2"
From: kontakt@beberlei.de (=?UTF-8?Q?Benjamin_Au=C3=9Fenhofer?=)

--00000000000008df54062e70a0d2
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Am 18.02.2025, 11:19:26 schrieb Jordi Boggiano <j.boggiano@seld.be>:

> Hey,
>
> K=C3=A9vin Dunglas and myself would like to present this RFC proposing
> inclusion of the zstandard and brotli pecl extensions into core, with
> the main goal of making them more broadly available.
>
> https://wiki.php.net/rfc/modern_compression
>
> Thanks for your consideration, we're looking forward to hearing your
> feedback!
>

I really like the idea to add both to core and the reasoning to add Brotli
as well given Safari constraints.

As Tim said, the API could use simplification and improvement. I would
propose that the constructor of a compressor gets all the options and the
interface method itself are really always single argument data in, data out=
.

For Zstd dictionary support you could just add a second class (or an
optional parameter) in the ctor. Rough idea (constant values and variable
names and types for ctors are mostly made up):

https://gist.github.com/beberlei/6f3d365f79959e3ded07e6a1f1351a1b

greetings
Benjamin

>
> Best,
> Jordi
>
> --
> Jordi Boggiano
> @seldaek - https://seld.be
>

--00000000000008df54062e70a0d2
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<html><body><div dir=3D"ltr">
    <br>
</div>
<br>
<div class=3D"gmail_quote" dir=3D"ltr">
    <div dir=3D"ltr" class=3D"gmail_attr">Am 18.02.2025, 11:19:26 schrieb J=
ordi Boggiano &lt;<a href=3D"mailto:j.boggiano@seld.be">j.boggiano@seld.be<=
/a>&gt;:<br></div>
    <blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bor=
der-left:1px solid rgb(204,204,204);padding-left:1ex" type=3D"cite">
       =20
<div>
<div>
    Hey,<br><br>K=C3=A9vin Dunglas and myself would like to present this RF=
C proposing <br>inclusion of the zstandard and brotli pecl extensions into =
core, with <br>the main goal of making them more broadly available.<br><br>=
<a href=3D"https://wiki.php.net/rfc/modern_compression">https://wiki.php.ne=
t/rfc/modern_compression</a><br><br>Thanks for your consideration, we&#39;r=
e looking forward to hearing your <br>feedback!<br></div></div></blockquote=
><div class=3D"gmail_quote"><br></div>I really like the idea to add both to=
 core and the reasoning to add Brotli as well given Safari constraints.</di=
v><div class=3D"gmail_quote" dir=3D"ltr"><br></div><div class=3D"gmail_quot=
e" dir=3D"ltr">As Tim said, the API could use simplification and improvemen=
t. I would propose that the constructor of a compressor gets all the option=
s and the interface method itself are really always single argument data in=
, data out.</div><div class=3D"gmail_quote" dir=3D"ltr"><br></div><div clas=
s=3D"gmail_quote" dir=3D"ltr">For Zstd dictionary support you could just ad=
d a second class (or an optional parameter) in the ctor. Rough idea (consta=
nt values and variable names and types for ctors are mostly made up):</div>=
<div class=3D"gmail_quote" dir=3D"ltr"><br></div><div class=3D"gmail_quote"=
 dir=3D"ltr"><a href=3D"https://gist.github.com/beberlei/6f3d365f79959e3ded=
07e6a1f1351a1b">https://gist.github.com/beberlei/6f3d365f79959e3ded07e6a1f1=
351a1b</a></div><div class=3D"gmail_quote" dir=3D"ltr"><br></div><div class=
=3D"gmail_quote" dir=3D"ltr">greetings</div><div class=3D"gmail_quote" dir=
=3D"ltr">Benjamin<br><blockquote class=3D"gmail_quote" style=3D"margin:0px =
0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" type=
=3D"cite"><div><div><br>Best,<br>Jordi<br><br>-- <br>Jordi Boggiano<br>@sel=
daek - <a href=3D"https://seld.be">https://seld.be</a><br>
</div>
</div>
    </blockquote>
</div></body></html>

--00000000000008df54062e70a0d2--