Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126449
Precedence: bulk
MIME-Version: 1.0
Date: Tue, 18 Feb 2025 14:55:32 +0100
To: Paul Dragoonis <dragoonis@gmail.com>
Cc: Jordi Boggiano <j.boggiano@seld.be>, Internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] Modern Compression (zstd, brotli)
In-Reply-To: <CAKxcST_VfZ9YNG93BOUKQ93qGVMbDk3ttUrekws-28LvYb-a0A@mail.gmail.com>
References: <528e16e1-1fb3-448a-b187-7cc84e1bcc4a@seld.be>
 <b24ce14ffc9382ef7784570fcdcaadb7@bastelstu.be>
 <5fa7423e-d723-451e-a73d-a98512a6ca96@seld.be>
 <8256945f09944cb16db34fd8139da63e@bastelstu.be>
 <CAKxcST_VfZ9YNG93BOUKQ93qGVMbDk3ttUrekws-28LvYb-a0A@mail.gmail.com>
Message-ID: <1856be6ad7a51bf5ea56001eb719897a@bastelstu.be>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

Am 2025-02-18 14:22, schrieb Paul Dragoonis:
> Having spent many years in PHP-FIG and lots of effort trying to build 
> one
> "standard" for lots of implementations that differ. I just want to 
> point
> out that I think we should avoid trying to make a standard design for 
> all
> the Compression drivers and features and instead agree that things 
> (Enums?)
> will and should differ from drive too driver and that'd okay.

Given that all compression algorithms work in a “put source data in get 
compressed data out” fashion, I believe it is reasonable to have an 
interface specifying that to allow for proper pluggability in the output 
pipeline:

     if (in_array('brotli', $request->getHeader('accept-encoding'))) {
         $compressor = new 
\Compression\Brotli\Compressor(\Compression\Brotli\Mode::Text);
     } elseif (in_array('zstd', $request->getHeader('accept-encoding'))) 
{
         $compressor = new \Compression\Zstd\Compressor();
     } elseif (in_array('gzip', $request->getHeader('accept-encoding'))) 
{
         $compressor = new \Compression\Gzip\Compressor(level: 6);
     } else {
         $compressor = new NullCompressor();
     }

     echo $compressor->compress($response->getBody());

I trust Jordi to come up with a reasonable API design.

Best regards
Tim Düsterhus