Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126411
Precedence: bulk
MIME-Version: 1.0
References: <a995ac24905030e168e7f6006b996cd5@bastelstu.be>
 <CAMzRQTcTrZR2=vnjvVZRt=fEJpiBci9HN36BQAwG8+FK60Gc1A@mail.gmail.com>
 <5c142df3-94f8-45ba-b5c6-af3b4f7caa8b@varteg.nz> <CAJmjfvUQEEnEVpjFTr_Kkzsjq5f1bfwtPDkKPhg=hXq-0EpzsQ@mail.gmail.com>
 <fabda1c573ff3c605c2b8da3e74eabf5@bastelstu.be> <8f0f99bf-70c3-c150-71b5-6b4760b72709@php.net>
 <897bd92a-69b4-47e0-a19d-a4da01f38182@alec.pl>
In-Reply-To: <897bd92a-69b4-47e0-a19d-a4da01f38182@alec.pl>
Date: Fri, 14 Feb 2025 15:00:55 +0100
Message-ID: <CAJmjfvU5aAjx1gP2+N5aJEo9aWLX7y18DCKq8zG1n7eX+=34Hg@mail.gmail.com>
Subject: Re: [PHP-DEV] Re: RFC: Marking return values as important (#[\NoDiscard])
To: Aleksander Machniak <alec@alec.pl>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="0000000000002d4cd0062e1a9bd1"
From: jakob@givoni.dk (Jakob Givoni)

--0000000000002d4cd0062e1a9bd1
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 14, 2025 at 1:10=E2=80=AFPM Aleksander Machniak <alec@alec.pl> =
wrote:

> On 14.02.2025 12:57, Derick Rethans wrote:
> > None of the current attributes (ReturnTypeWillChange,
> > AllowDynamicProperties, SensitiveParameter, Override, and Deprecated)
> > change the behaviour of how a program runs. They only add warnings. wit=
h
> > the exception of AllowDynamicProperties to be an actual 'feature' in PH=
P
> > 9.0 (now it's only a deprecation warning silencer).
>
> For clarity, it's not AllowDynamicProperties attribute throwing an
> exception in PHP9, it's use of a "dynamic" property on an object not
> marked with this attribute. So, I'm not sure it's a valid exception to
> the rule.
>
>
You're absolutely right that it's not the use of the property that causes
exceptions
to be thrown, *but it's still a valid exception* to the rule, since the use
of the property
changes how a program runs (which was the point that was being made).

Best,
Jakob

--0000000000002d4cd0062e1a9bd1
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><div class=3D"gmail_quote gmail=
_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Feb 14, 202=
5 at 1:10=E2=80=AFPM Aleksander Machniak &lt;<a href=3D"mailto:alec@alec.pl=
">alec@alec.pl</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" st=
yle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padd=
ing-left:1ex">On 14.02.2025 12:57, Derick Rethans wrote:<br>
&gt; None of the current attributes (ReturnTypeWillChange,<br>
&gt; AllowDynamicProperties, SensitiveParameter, Override, and Deprecated)<=
br>
&gt; change the behaviour of how a program runs. They only add warnings. wi=
th<br>
&gt; the exception of AllowDynamicProperties to be an actual &#39;feature&#=
39; in PHP<br>
&gt; 9.0 (now it&#39;s only a deprecation warning silencer).<br>
<br>
For clarity, it&#39;s not AllowDynamicProperties attribute throwing an <br>
exception in PHP9, it&#39;s use of a &quot;dynamic&quot; property on an obj=
ect not <br>
marked with this attribute. So, I&#39;m not sure it&#39;s a valid exception=
 to <br>
the rule.<br>
<br></blockquote><div><br></div><div>You&#39;re absolutely right that it=
9;s not the use of the property that causes exceptions</div><div>to be thro=
wn, <b>but it&#39;s still a valid exception</b> to the rule, since the use =
of the property</div><div>changes how a program runs (which was the point t=
hat was being made).</div><div><br></div><div>Best,</div><div>Jakob</div><d=
iv><br></div><div>=C2=A0</div></div></div>

--0000000000002d4cd0062e1a9bd1--