Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126406
Date: Fri, 14 Feb 2025 11:57:02 +0000 (GMT)
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
cc: Jakob Givoni <jakob@givoni.dk>, volker@tideways-gmbh.com, 
    internals@lists.php.net
Subject: Re: [PHP-DEV] Re: RFC: Marking return values as important
 (#[\NoDiscard])
In-Reply-To: <fabda1c573ff3c605c2b8da3e74eabf5@bastelstu.be>
Message-ID: <8f0f99bf-70c3-c150-71b5-6b4760b72709@php.net>
References: <a995ac24905030e168e7f6006b996cd5@bastelstu.be> <CAMzRQTcTrZR2=vnjvVZRt=fEJpiBci9HN36BQAwG8+FK60Gc1A@mail.gmail.com> <5c142df3-94f8-45ba-b5c6-af3b4f7caa8b@varteg.nz> <CAJmjfvUQEEnEVpjFTr_Kkzsjq5f1bfwtPDkKPhg=hXq-0EpzsQ@mail.gmail.com>
 <fabda1c573ff3c605c2b8da3e74eabf5@bastelstu.be>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1786628913-1739534223=:13815"
From: derick@php.net (Derick Rethans)

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1786628913-1739534223=:13815
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Thu, 13 Feb 2025, Tim D=C3=BCsterhus wrote:

> Am 2025-02-13 09:16, schrieb Jakob Givoni:
>
> > Attributes were added as a structured replacement for docblock props=20
> > and I don't like it when they affect how a program actually runs (as=20
> > long as you're not using reflection).
>=20
> Excluding the `#[\Attribute]` attribute, PHP currently has 5 native=20
> attributes and they all affect how the program runs. The initial=20
> accepted Attribute RFC even lists several =E2=80=9Cbehavior-affecting=E2=
=80=9D=20
> attributes in the =E2=80=9CUse Cases=E2=80=9D section:=20
> https://wiki.php.net/rfc/attributes_v2#use_cases. It is probably fair=20
> to say that use-cases like `#[\NoDiscard]` do not go against the=20
> vision intended by the Attribute RFC.
>=20
> You could think of it as the PHP engine using Reflection internally to=20
> do something differently.

I don't agree, but for a different reason.

None of the current attributes (ReturnTypeWillChange,=20
AllowDynamicProperties, SensitiveParameter, Override, and Deprecated)=20
change the behaviour of how a program runs. They only add warnings. with=20
the exception of AllowDynamicProperties to be an actual 'feature' in PHP=20
9.0 (now it's only a deprecation warning silencer).

That's the same with this suggested NoDiscard, it doesn't change how a=20
program is run =E2=80=94 it merely adds a warning.

cheers,
Derick
--8323329-1786628913-1739534223=:13815--