Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126378
Message-ID: <e5edbe8f-5622-4f0d-9c07-aa0a797b9222@scriptfusion.com>
Date: Wed, 12 Feb 2025 13:17:55 +0000
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] RFC: Marking return values as important (#[\NoDiscard])
To: internals@lists.php.net
References: <a995ac24905030e168e7f6006b996cd5@bastelstu.be>
Content-Language: en-GB
In-Reply-To: <a995ac24905030e168e7f6006b996cd5@bastelstu.be>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: bilge@scriptfusion.com (Bilge)

On 29/01/2025 15:12, Tim Düsterhus wrote:
> Hi
>
> Volker and I would like to start discussion on our RFC to allow 
> "Marking return values as important (#[\NoDiscard])".
>
> Please find the following resources for your reference:
>
> - RFC: https://wiki.php.net/rfc/marking_return_value_as_important
> - Implementation: https://github.com/php/php-src/pull/17599
>
> Best regards
> Tim Düsterhus

Apologies if this has already been brought up; I haven't read the entire 
thread, but isn't the entire premise of this RFC based on a falsehood?

 >This kind of “partial success” can only be reliably communicated by 
means of a return value

Exceptions are objects, so you can attach whatever additional 
information you wish to that object.

Perhaps the word "reliably" is doing a lot of heavy lifting in that 
sentence, but if you would refute me (which presumably you will), then I 
think this needs to be explained in better detail in the RFC, because it 
looks to me that exploiting object properties is just as viable as 
returning something, and probably preferred, since this solves your 
problem of the user not handling the failure.

Cheers,
Bilge