Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126354
Precedence: bulk
MIME-Version: 1.0
References: <CAD91n9L6B7fe1wtqqeOH+6PT1so-+TxB3uOEuVDL7W5T+U27Lw@mail.gmail.com>
 <8053193b-0637-4db4-825d-56e7746111dd@bastelstu.be> <e0ef2efc-2933-451a-9259-b6c9d5491bdf@app.fastmail.com>
In-Reply-To: <e0ef2efc-2933-451a-9259-b6c9d5491bdf@app.fastmail.com>
Date: Sat, 8 Feb 2025 12:16:46 -0500
Message-ID: <CAD91n9KpV+G8WpJAcjmUb_yYnzXf6Ev7NE-w=8or5Uh-7GWZ8Q@mail.gmail.com>
Subject: Re: [PHP-DEV] Introduction - Sam Lewis
To: Rob Landers <rob@bottled.codes>
Cc: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>, internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000f7df72062da4a5c6"
From: sam.lewis0602@gmail.com (Sam Lewis)

--000000000000f7df72062da4a5c6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thanks all for sharing your thoughts!

I would be happy to review your implementation even if you decide not to
> follow through with an RFC (ping @TimWolla on GitHub)

I'll definitely take you up on this, thank you.

Why stop at temperature though

That's fair, maybe that will increase the value proposition of the RFC
enough to be worth considering more seriously.

Sam

On Sat, Feb 8, 2025 at 10:05=E2=80=AFAM Rob Landers <rob@bottled.codes> wro=
te:

> On Sat, Feb 8, 2025, at 15:58, Tim D=C3=BCsterhus wrote:
>
> Hi Sam
>
> On 2/8/25 15:30, Sam Lewis wrote:
> > they wished PHP had built-in functions for converting temperatures
> between
> > Fahrenheit and Celcius, and it seemed like a great small change to lear=
n
> > how to contribute to PHP itself. So here I am!
>
> That's great. Adding functions definitely is the best way to get one=E2=
=80=99s
> feet wet with contributing to PHP itself.
>
> That said, PHP=E2=80=99s standard library is already pretty large and any=
 new
> addition should provide value to a large number of projects, given the
> amount of work associated with it. A new function might conflict with
> existing userland functions having the same name, it needs to be
> documented (and documentation translated), it needs to be maintained for
> 20+ years and of course there's all the overhead of the RFC process.
>
> I'm not sure if functionality to convert between Fahrenheit and Celsius
> reaches that bar of usefulness and I doubt that an RFC proposing those
> would pass.
>
> I don't mean to discourage you from contributing and if you want, I
> would be happy to review your implementation even if you decide not to
> follow through with an RFC (ping @TimWolla on GitHub), perhaps it will
> be useful for any other functionality you might come up with in the futur=
e.
>
> And of course if you still plan to do the RFC that's also fine. But
> someone else will need to grant you the RFC karma, as I do not have the
> permissions to do so.
>
> Best regards
> Tim D=C3=BCsterhus
>
>
> Why stop at temperature though. It would (actually) be very useful to hav=
e
> a standard (built-in) way for units conversion in-general. Not just for
> Celsius to Fahrenheit, but also Kelvin. Hours, minutes, seconds, etc, as
> well. DateTime kinda-sorta handles time already -- if a bit clumsily.
>
> =E2=80=94 Rob
>

--000000000000f7df72062da4a5c6
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Thanks all for sharing your thoughts!</div><div><br><=
/div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bo=
rder-left:1px solid rgb(204,204,204);padding-left:1ex">I would be happy to =
review your implementation even if you decide not to follow through with an=
 RFC (ping @TimWolla on GitHub)</blockquote><div>I&#39;ll definitely take y=
ou up on this, thank you.</div><div><br></div><blockquote class=3D"gmail_qu=
ote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,20=
4);padding-left:1ex">Why stop at temperature though</blockquote><div>That&#=
39;s fair, maybe that will increase the value proposition of the RFC enough=
 to be worth considering more seriously. <br></div><div><br></div><div>Sam<=
br></div></div><br><div class=3D"gmail_quote gmail_quote_container"><div di=
r=3D"ltr" class=3D"gmail_attr">On Sat, Feb 8, 2025 at 10:05=E2=80=AFAM Rob =
Landers &lt;rob@bottled.codes&gt; wrote:<br></div><blockquote class=3D"gmai=
l_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,20=
4,204);padding-left:1ex"><div class=3D"msg5339322613040921361"><u></u><div>=
<div>On Sat, Feb 8, 2025, at 15:58, Tim D=C3=BCsterhus wrote:<br></div><blo=
ckquote type=3D"cite" id=3D"m_5339322613040921361qt"><div>Hi Sam<br></div><=
div><br></div><div>On 2/8/25 15:30, Sam Lewis wrote:<br></div><div>&gt; the=
y wished PHP had built-in functions for converting temperatures between<br>=
</div><div>&gt; Fahrenheit and Celcius, and it seemed like a great small ch=
ange to learn<br></div><div>&gt; how to contribute to PHP itself. So here I=
 am!<br></div><div><br></div><div>That&#39;s great. Adding functions defini=
tely is the best way to get one=E2=80=99s=C2=A0<br></div><div>feet wet with=
 contributing to PHP itself.<br></div><div><br></div><div>That said, PHP=E2=
=80=99s standard library is already pretty large and any new=C2=A0<br></div=
><div>addition should provide value to a large number of projects, given th=
e=C2=A0<br></div><div>amount of work associated with it. A new function mig=
ht conflict with=C2=A0<br></div><div>existing userland functions having the=
 same name, it needs to be=C2=A0<br></div><div>documented (and documentatio=
n translated), it needs to be maintained for=C2=A0<br></div><div>20+ years =
and of course there&#39;s all the overhead of the RFC process.<br></div><di=
v><br></div><div>I&#39;m not sure if functionality to convert between Fahre=
nheit and Celsius=C2=A0<br></div><div>reaches that bar of usefulness and I =
doubt that an RFC proposing those=C2=A0<br></div><div>would pass.<br></div>=
<div><br></div><div>I don&#39;t mean to discourage you from contributing an=
d if you want, I=C2=A0<br></div><div>would be happy to review your implemen=
tation even if you decide not to=C2=A0<br></div><div>follow through with an=
 RFC (ping @TimWolla on GitHub), perhaps it will=C2=A0<br></div><div>be use=
ful for any other functionality you might come up with in the future.<br></=
div><div><br></div><div>And of course if you still plan to do the RFC that&=
#39;s also fine. But=C2=A0<br></div><div>someone else will need to grant yo=
u the RFC karma, as I do not have the=C2=A0<br></div><div>permissions to do=
 so.<br></div><div><br></div><div>Best regards<br></div><div>Tim D=C3=BCste=
rhus<br></div><div><br></div></blockquote><div><br></div><div>Why stop at t=
emperature though. It would (actually) be very useful to have a standard (b=
uilt-in) way for units conversion in-general. Not just for Celsius to Fahre=
nheit, but also Kelvin. Hours, minutes, seconds, etc, as well. DateTime kin=
da-sorta handles time already -- if a bit clumsily.=C2=A0</div><div><br></d=
iv><div id=3D"m_5339322613040921361sig121229152">=E2=80=94 Rob<br></div></d=
iv></div></blockquote></div>

--000000000000f7df72062da4a5c6--