Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126352
Feedback-ID: ifab94697:Fastmail
Precedence: bulk
MIME-Version: 1.0
Date: Sat, 08 Feb 2025 16:05:34 +0100
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>,
 "Sam Lewis" <sam.lewis0602@gmail.com>, internals@lists.php.net
Message-ID: <e0ef2efc-2933-451a-9259-b6c9d5491bdf@app.fastmail.com>
In-Reply-To: <8053193b-0637-4db4-825d-56e7746111dd@bastelstu.be>
References: 
 <CAD91n9L6B7fe1wtqqeOH+6PT1so-+TxB3uOEuVDL7W5T+U27Lw@mail.gmail.com>
 <8053193b-0637-4db4-825d-56e7746111dd@bastelstu.be>
Subject: Re: [PHP-DEV] Introduction - Sam Lewis
Content-Type: multipart/alternative;
 boundary=40c4deab916e40848711a67967f9167d
From: rob@bottled.codes ("Rob Landers")

--40c4deab916e40848711a67967f9167d
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Sat, Feb 8, 2025, at 15:58, Tim D=C3=BCsterhus wrote:
> Hi Sam
>=20
> On 2/8/25 15:30, Sam Lewis wrote:
> > they wished PHP had built-in functions for converting temperatures b=
etween
> > Fahrenheit and Celcius, and it seemed like a great small change to l=
earn
> > how to contribute to PHP itself. So here I am!
>=20
> That's great. Adding functions definitely is the best way to get one=E2=
=80=99s=20
> feet wet with contributing to PHP itself.
>=20
> That said, PHP=E2=80=99s standard library is already pretty large and =
any new=20
> addition should provide value to a large number of projects, given the=20
> amount of work associated with it. A new function might conflict with=20
> existing userland functions having the same name, it needs to be=20
> documented (and documentation translated), it needs to be maintained f=
or=20
> 20+ years and of course there's all the overhead of the RFC process.
>=20
> I'm not sure if functionality to convert between Fahrenheit and Celsiu=
s=20
> reaches that bar of usefulness and I doubt that an RFC proposing those=20
> would pass.
>=20
> I don't mean to discourage you from contributing and if you want, I=20
> would be happy to review your implementation even if you decide not to=20
> follow through with an RFC (ping @TimWolla on GitHub), perhaps it will=20
> be useful for any other functionality you might come up with in the fu=
ture.
>=20
> And of course if you still plan to do the RFC that's also fine. But=20
> someone else will need to grant you the RFC karma, as I do not have th=
e=20
> permissions to do so.
>=20
> Best regards
> Tim D=C3=BCsterhus
>=20

Why stop at temperature though. It would (actually) be very useful to ha=
ve a standard (built-in) way for units conversion in-general. Not just f=
or Celsius to Fahrenheit, but also Kelvin. Hours, minutes, seconds, etc,=
 as well. DateTime kinda-sorta handles time already -- if a bit clumsily=
.=20

=E2=80=94 Rob
--40c4deab916e40848711a67967f9167d
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Sat, Feb 8, =
2025, at 15:58, Tim D=C3=BCsterhus wrote:<br></div><blockquote type=3D"c=
ite" id=3D"qt" style=3D""><div>Hi Sam<br></div><div><br></div><div>On 2/=
8/25 15:30, Sam Lewis wrote:<br></div><div>&gt; they wished PHP had buil=
t-in functions for converting temperatures between<br></div><div>&gt; Fa=
hrenheit and Celcius, and it seemed like a great small change to learn<b=
r></div><div>&gt; how to contribute to PHP itself. So here I am!<br></di=
v><div><br></div><div>That's great. Adding functions definitely is the b=
est way to get one=E2=80=99s&nbsp;<br></div><div>feet wet with contribut=
ing to PHP itself.<br></div><div><br></div><div>That said, PHP=E2=80=99s=
 standard library is already pretty large and any new&nbsp;<br></div><di=
v>addition should provide value to a large number of projects, given the=
&nbsp;<br></div><div>amount of work associated with it. A new function m=
ight conflict with&nbsp;<br></div><div>existing userland functions havin=
g the same name, it needs to be&nbsp;<br></div><div>documented (and docu=
mentation translated), it needs to be maintained for&nbsp;<br></div><div=
>20+ years and of course there's all the overhead of the RFC process.<br=
></div><div><br></div><div>I'm not sure if functionality to convert betw=
een Fahrenheit and Celsius&nbsp;<br></div><div>reaches that bar of usefu=
lness and I doubt that an RFC proposing those&nbsp;<br></div><div>would =
pass.<br></div><div><br></div><div>I don't mean to discourage you from c=
ontributing and if you want, I&nbsp;<br></div><div>would be happy to rev=
iew your implementation even if you decide not to&nbsp;<br></div><div>fo=
llow through with an RFC (ping @TimWolla on GitHub), perhaps it will&nbs=
p;<br></div><div>be useful for any other functionality you might come up=
 with in the future.<br></div><div><br></div><div>And of course if you s=
till plan to do the RFC that's also fine. But&nbsp;<br></div><div>someon=
e else will need to grant you the RFC karma, as I do not have the&nbsp;<=
br></div><div>permissions to do so.<br></div><div><br></div><div>Best re=
gards<br></div><div>Tim D=C3=BCsterhus<br></div><div><br></div></blockqu=
ote><div><br></div><div>Why stop at temperature though. It would (actual=
ly) be very useful to have a standard (built-in) way for units conversio=
n in-general. Not just for Celsius to Fahrenheit, but also Kelvin. Hours=
, minutes, seconds, etc, as well. DateTime kinda-sorta handles time alre=
ady -- if a bit clumsily.&nbsp;</div><div><br></div><div id=3D"sig121229=
152">=E2=80=94 Rob<br></div></body></html>
--40c4deab916e40848711a67967f9167d--