Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126351
Message-ID: <8053193b-0637-4db4-825d-56e7746111dd@bastelstu.be>
Date: Sat, 8 Feb 2025 15:58:58 +0100
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] Introduction - Sam Lewis
To: Sam Lewis <sam.lewis0602@gmail.com>, internals@lists.php.net
References: <CAD91n9L6B7fe1wtqqeOH+6PT1so-+TxB3uOEuVDL7W5T+U27Lw@mail.gmail.com>
Content-Language: en-US
In-Reply-To: <CAD91n9L6B7fe1wtqqeOH+6PT1so-+TxB3uOEuVDL7W5T+U27Lw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi Sam

On 2/8/25 15:30, Sam Lewis wrote:
> they wished PHP had built-in functions for converting temperatures between
> Fahrenheit and Celcius, and it seemed like a great small change to learn
> how to contribute to PHP itself. So here I am!

That's great. Adding functions definitely is the best way to get one’s 
feet wet with contributing to PHP itself.

That said, PHP’s standard library is already pretty large and any new 
addition should provide value to a large number of projects, given the 
amount of work associated with it. A new function might conflict with 
existing userland functions having the same name, it needs to be 
documented (and documentation translated), it needs to be maintained for 
20+ years and of course there's all the overhead of the RFC process.

I'm not sure if functionality to convert between Fahrenheit and Celsius 
reaches that bar of usefulness and I doubt that an RFC proposing those 
would pass.

I don't mean to discourage you from contributing and if you want, I 
would be happy to review your implementation even if you decide not to 
follow through with an RFC (ping @TimWolla on GitHub), perhaps it will 
be useful for any other functionality you might come up with in the future.

And of course if you still plan to do the RFC that's also fine. But 
someone else will need to grant you the RFC karma, as I do not have the 
permissions to do so.

Best regards
Tim Düsterhus