Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126315
Message-ID: <906cf238-99df-4ffb-981e-925a2125fc5f@gmx.de>
Date: Thu, 6 Feb 2025 23:11:42 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: PHP internals <internals@lists.php.net>
Content-Language: de-DE
Subject: [PHP-DEV] Update DOM extension version?
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
UI-OutboundReport: notjunk:1;M01:P0:/QvS5/pkpgY=;05cY8v+4V9GQDDyjKB1TbeVmT1z
 SQrljKvWR2hIGETkPPsrbTnUojwd1UF62E4mTM1IU52bWTZlw6Lu+cXmztts7NiK/0zSDnVCk
 anEVfTtwneIlgmvkK3EHtQKO1ecgnETJseihsUXQyVmveRo+BThTX+i+8lzwFIkiFSXhtfsU+
 u8mLRB9KFC+aD+77yKOD2CiFkse4FvLvBuSbdBXASsVXLmWx1QVookdluVoYO+EPSm7PcqlEY
 aRHmb9ip2xegY8P2y6nuaeNy//NFCFPxEcHiS+JOjsdiVi8B7Z9eyH4r4qQ+3n7Iryu52dAif
 zf+O3pdzFj5gygcGDPUqCU7WurWvJTC2gHE7Hvgp1FsKeuosvb7UavwSEVd0Z9Q8igkh5zCnI
 lR/cgnQzbtxUPjUnvE+JkkUTw379k+dAyn4+X08Vj6oPveMpeAfY2ZLMffMbeD8R+bgHDGViR
 3ZObJyS2q2SY2u8IMUpoN25WaC7MVjRFh18PvAIruU0o2V1eDKi+r1yW5vJ8+zeX3qrt/VOK7
 zQbUcBGgfpVTGpKea9nH9YiUWR2iqNnvmnGE731iwvC+3usXGnbHSDotv2MFjyff2Egzi1sdY
 wI9qiwjqrsOLS8Xu3wY1tT+euSFJJmMY/EdWxjCryMeRiXkgz8FLoQj2a5laquMpFuN1fOgG2
 HutStw5B2pC73At1VtzWRgbAkLqXjRnK5TgihGHLR9cjiSgNLAuI1KWtPZj7PhS+JgdZjcP+K
 vk/Lced3e3gE2cK6z7Z13eqlXF/8ataBH74z0lbENf6Po9iZzpb+nTR5IFrQ/K7CnS5ATTQS7
 xlKhFvN65glWwKEhMRnUZx8G0ginXQvRNBuGEVoeUd3/ehnj7GIS3WQLOu36Nd14tFkscXHPx
 pgZIp2iiFBlOZMdXrIu22Xob2m3J/DFF4uKkymEYSyP0F9axSGRv79OBQb7O0Yv5bUNN5kR99
 Fpz1mbN2K/MrMgv8ncXMzVMVh3nmhF9z5e+/SlK7bJSw0Yi3sJigAcrOMp7lkHFqYtSQFOQ1s
 HFHpKJG1MjDyYBRcyNxJkQxFhBtry3TxY9187Z9+AbSjy3no6+0ds7v979hPjPocjke1zVL3b
 M6C2NdDXcNiWkan5N51eIvsgg284atfjT/ruPgiEO3EVRdPvhdhOBTdm0G8pEhQVc+TTEroVp
 V61djCdf+v0wmW8YF10/0kajTt83MlOPEDOesXNpm68QA9turgrEfqxVy6LAXJvjffY9vSaaZ
 KV90wHXt3hjndlHJRF7v0eHuS+1/V6Fs3jOYTJwaclAT0oOYuqc0KKNMS29pG60U+2mvX3g+a
 Pd2NuF5jb5Rd58PmiBbKTdKQnjbHOGtuJiZLXm8ZmnwpK5jqBmj9p9Uri/1VT/7hDi3oNJxCg
 An32uBmZEgfj4uMjWOvPXU1Z/O7I+ehSfHOwux70/6GMMFqzEcShlZ6BMgSi9RrXOru5MkAz6
 3JQCfsdyonowLY3QNXz+634n7z9Y=
From: cmbecker69@gmx.de ("Christoph M. Becker")

Hi all,

recently, I've stumbled upon an older bug report which claimed that the
version of ext/dom would be incorrect[1].  Since this still is reported
as "20031129" (!), I submitted a PR[2] to update that according to the
usual convention that bundled extensions report the same version as PHP
(e.g. "8.5.0-dev").  However, Niels was concerned that this could break
consumers, since the new version would be less than the old version.  I
followed up with a change to use the stringified ZEND_MODULE_API_NO
(e.g. "20240925").  While that would solve the version
"incompatibility", it seems that some code (e.g. composer.json) relies
on the exact "20031129" version (no wonder, since this is stable for
more than 20 years).

Now the question is, if we want to update the version number, and which
scheme we want to use.  Is it nobler to bow to the historic mistake not
to update the version earlier (and stick with a completely useless DOM
version), or to possibly break existing consumers (for the sake of
offering a somewhat meaningful ext/dom version in the future)?

In hindsight, going to ZEND_MODULE_API_NO would not make sense at all;
while that might reduce BC breakage, it still is not meaningful, since
that is already catered to by not being able to load extensions with a
different ZEND_MODULE_API_NO.  Using PHP_VERSION, on the other hand,
might allow consumers to require e.g. PHP 8.5.*, but to still require
ext/dom ~8.5.7, for instance.

Currently, I tend to prefer to update to PHP_VERSION, possibly delaying
that to PHP 9, where a break might be more acceptable.  I'm looking
forward to hear about your opinion.

[1] <https://github.com/php/php-src/issues/8038>
[2] <https://github.com/php/php-src/pull/17702>

Christoph