Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126305
Precedence: bulk
MIME-Version: 1.0
References: <2861271a800eddea62c7fe93b32b2fab@bastelstu.be>
In-Reply-To: <2861271a800eddea62c7fe93b32b2fab@bastelstu.be>
Date: Thu, 6 Feb 2025 11:33:02 +0100
Message-ID: <CAEKnhAFAG1FXi9cFNs7j5u35j_V-y1WygM8ZUpsms4i6n2wz+g@mail.gmail.com>
Subject: Re: [PHP-DEV] Allow to easily retrieve non-default INI settings / GH
 PR 17459
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000e94d97062d76c471"
From: bukka@php.net (Jakub Zelenka)

--000000000000e94d97062d76c471
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Feb 6, 2025 at 9:57=E2=80=AFAM Tim D=C3=BCsterhus <tim@bastelstu.be=
> wrote:

> Hi
>
> this email concerns my PR https://github.com/php/php-src/pull/17459,
> which extended the cli-SAPI=E2=80=99s `--ini` flag to print any INI setti=
ngs
> that differ from the built-in default. There was some discussion around
> which flag to use, which didn't result in particularly strong opinions,
> with the PR being merged in the current state, given there is plenty of
> time until feature freeze for follow-ups.
>
> After the merge, this came up again and I'm now reaching out to
> Internals for other folks to weigh in. Those of you who have an opinion
> about the flag (and possible BC concerns with using the existing `--ini`
> flag), please comment on the PR (or this ML thread). If necessary I can
> do a small RFC / straw poll about this, but I hope that the feature is
> sufficiently simple to not require a formal process :-)
>
>
As I mentioned in the PR I don't see a reason why that option should be
extended to also contain diff which will be mostly quite useless if one
just want to see the configuration files. I can see why someone would want
the diff functionality but it should be probably using a different option
or the previously suggested --ini=3Ddiff. Personally I don't really mind wh=
at
it is, just not using the same one.

Cheers

Jakub

--000000000000e94d97062d76c471
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi,</div><div><br></div><div dir=3D"ltr">On Thu, Feb =
6, 2025 at 9:57=E2=80=AFAM Tim D=C3=BCsterhus &lt;<a href=3D"mailto:tim@bas=
telstu.be">tim@bastelstu.be</a>&gt; wrote:</div><div class=3D"gmail_quote g=
mail_quote_container"><blockquote class=3D"gmail_quote" style=3D"margin:0px=
 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi<=
br>
<br>
this email concerns my PR <a href=3D"https://github.com/php/php-src/pull/17=
459" rel=3D"noreferrer" target=3D"_blank">https://github.com/php/php-src/pu=
ll/17459</a>, <br>
which extended the cli-SAPI=E2=80=99s `--ini` flag to print any INI setting=
s <br>
that differ from the built-in default. There was some discussion around <br=
>
which flag to use, which didn&#39;t result in particularly strong opinions,=
 <br>
with the PR being merged in the current state, given there is plenty of <br=
>
time until feature freeze for follow-ups.<br>
<br>
After the merge, this came up again and I&#39;m now reaching out to <br>
Internals for other folks to weigh in. Those of you who have an opinion <br=
>
about the flag (and possible BC concerns with using the existing `--ini` <b=
r>
flag), please comment on the PR (or this ML thread). If necessary I can <br=
>
do a small RFC / straw poll about this, but I hope that the feature is <br>
sufficiently simple to not require a formal process :-)<br><br></blockquote=
><div><br></div><div>As I mentioned in the PR I don&#39;t see a reason why =
that option should be extended to also contain diff which will be mostly qu=
ite useless if one just want to see the configuration files. I can see why =
someone would want the diff functionality but it should be probably using a=
 different option or the previously suggested --ini=3Ddiff. Personally I do=
n&#39;t really mind what it is, just not using the same one.</div><div><br>=
</div><div>Cheers</div><div><br></div><div>Jakub</div></div></div>

--000000000000e94d97062d76c471--