Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126299
Precedence: bulk
MIME-Version: 1.0
References: <cbe7b1ea-4d23-4b7c-9dd9-f400ca7c5d11@gmx.de>
In-Reply-To: <cbe7b1ea-4d23-4b7c-9dd9-f400ca7c5d11@gmx.de>
Date: Wed, 5 Feb 2025 17:43:36 +0100
Message-ID: <CAEKnhAEXtje5MsOsZyqtTH4LxcdAejUyNyX9U82+XWZLYn6Vew@mail.gmail.com>
Subject: Re: [PHP-DEV] Deprecate filter_input() or not?
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000005a9fca062d67d481"
From: bukka@php.net (Jakub Zelenka)

--0000000000005a9fca062d67d481
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, Feb 5, 2025 at 2:15=E2=80=AFPM Christoph M. Becker <cmbecker69@gmx.=
de>
wrote:

> Hi all!
>
> There is some discussion on a recent bug report[1] about filter_input()
> and related functionality.  The bug report had been closed, because this
> functionality has already been added to the general deprecation RFC for
> PHP 8.5[2].  Then the OP raised a point regarding the usefulness of
> filter_input() to get at the original input, to avoid working with
> possibly modified superglobals.
>
>
It was actually closed because of misunderstanding of the requested envs
that are supplied by SAPI. So it's now re-open. We should also never close
anything because it got to the drafted deprecation list. It can be closed
only if it really gets deprecated.


> In my opinion, this topic should be discussed here, and not in a bug
> report.  So, has anybody thoughts about the filter_input() deprecation?
>
>
I don't think we should deprecate it. It's used in many applications.

Cheers

Jakub

--0000000000005a9fca062d67d481
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi,</div><br><div class=3D"gmail_quote gmail_quote_co=
ntainer"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Feb 5, 2025 at 2:15=
=E2=80=AFPM Christoph M. Becker &lt;<a href=3D"mailto:cmbecker69@gmx.de">cm=
becker69@gmx.de</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pad=
ding-left:1ex">Hi all!<br>
<br>
There is some discussion on a recent bug report[1] about filter_input()<br>
and related functionality.=C2=A0 The bug report had been closed, because th=
is<br>
functionality has already been added to the general deprecation RFC for<br>
PHP 8.5[2].=C2=A0 Then the OP raised a point regarding the usefulness of<br=
>
filter_input() to get at the original input, to avoid working with<br>
possibly modified superglobals.<br>
<br></blockquote><div><br></div><div>It was actually closed because of misu=
nderstanding of the requested envs that are supplied by SAPI. So it&#39;s n=
ow re-open. We should also never close anything because it got to the draft=
ed deprecation list. It can be closed only if it really gets deprecated.</d=
iv><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0=
px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
In my opinion, this topic should be discussed here, and not in a bug<br>
report.=C2=A0 So, has anybody thoughts about the filter_input() deprecation=
?<br><br></blockquote><div><br></div><div>I don&#39;t think we should depre=
cate it. It&#39;s used in many applications.</div><div><br></div><div>Cheer=
s</div><div><br></div><div>Jakub</div></div></div>

--0000000000005a9fca062d67d481--