Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126292
Precedence: bulk
MIME-Version: 1.0
References: <a995ac24905030e168e7f6006b996cd5@bastelstu.be> <7175feba-85ea-ce60-f89c-36ea1a7ed574@php.net>
In-Reply-To: <7175feba-85ea-ce60-f89c-36ea1a7ed574@php.net>
Date: Wed, 5 Feb 2025 11:58:19 +0100
Message-ID: <CAMzRQTfqiHFfnF-D9RTphignUiWH_0FS9GzrnntvDHB1gLxQ3Q@mail.gmail.com>
Subject: Re: [PHP-DEV] RFC: Marking return values as important (#[\NoDiscard])
To: Derick Rethans <derick@php.net>
Cc: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>, 
	php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000847b65062d63016f"
From: volker@tideways-gmbh.com (Volker Dusch)

--000000000000847b65062d63016f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 4, 2025 at 12:10=E2=80=AFPM Derick Rethans <derick@php.net> wro=
te:

> What's the reason why this emits a warning though, instead of throwing
> an Exception? I'm sure you thought of it, but it would be nice to have
> that consideration mentioned in the RFC.
>

Thank you for the question, I now added the missing reasoning to the RFC
text.

> A <php>E_(USER_)WARNING</php> was chosen over an exception to avoid BC
concerns, as throwing would potentially break existing code that "works as
implemented" and because this is only a warning in the literal sense of the
word, given that the function executes successfully.

Given that PHP uses Exceptions only in hard failure cases, we found it to
be more prudent to go this way. If users really want, they can
suppress/ignore this warning without adapting existing code, e.g., using
the proposed (void) cast. But the main reason was to not cause hard
failures through exceptions.

Kind Regards,
Volker

--=20
Volker Dusch
Head of Engineering
Tideways GmbH
K=C3=B6nigswinterer Str. 116
53227 Bonn
https://tideways.io/imprint

Sitz der Gesellschaft: Bonn
Gesch=C3=A4ftsf=C3=BChrer: Benjamin Au=C3=9Fenhofer (geb. Eberlei)
Registergericht: Amtsgericht Bonn, HRB 22127

--000000000000847b65062d63016f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><div dir=
=3D"ltr" class=3D"gmail_attr">On Tue, Feb 4, 2025 at 12:10=E2=80=AFPM Deric=
k Rethans &lt;<a href=3D"mailto:derick@php.net">derick@php.net</a>&gt; wrot=
e:</div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border=
-left:1px #ccc solid;padding-left:1ex">
What&#39;s the reason why this emits a warning though, instead of throwing =
<br>
an Exception? I&#39;m sure you thought of it, but it would be nice to have =
<br>
that consideration mentioned in the RFC.<br></blockquote><div><br></div><di=
v>Thank you for the question, I now added the missing reasoning to the RFC =
text.</div><div><br></div><div>&gt;=C2=A0A &lt;php&gt;E_(USER_)WARNING&lt;/=
php&gt; was chosen over an exception to avoid BC concerns, as throwing woul=
d potentially break existing code that &quot;works as implemented&quot; and=
 because this is only a warning in the literal sense of the word, given tha=
t the function executes successfully.</div><div><br></div><div>Given that P=
HP uses Exceptions only in hard failure cases, we found it to be more prude=
nt to go this way. If users really want, they can suppress/ignore this warn=
ing without adapting existing code, e.g., using the proposed (void) cast. B=
ut the main reason was to not cause hard failures through exceptions.</div>=
<div><br></div><div>Kind Regards,</div><div>Volker</div><div><br></div></di=
v><span class=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" cla=
ss=3D"gmail_signature" data-smartmail=3D"gmail_signature"><div dir=3D"ltr">=
<div style=3D"color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12=
.8px">Volker Dusch</div><div style=3D"color:rgb(34,34,34);font-family:arial=
,sans-serif;font-size:12.8px">Head of Engineering</div><div style=3D"color:=
rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px"><div>Tideways =
GmbH</div><div>K=C3=B6nigswinterer Str. 116</div><div>53227 Bonn</div><div>=
<a href=3D"https://tideways.io/imprint" style=3D"color:rgb(17,85,204)" targ=
et=3D"_blank">https://tideways.io/imprint</a><br></div><div><br></div><div>=
Sitz der Gesellschaft: Bonn</div><div>Gesch=C3=A4ftsf=C3=BChrer: Benjamin A=
u=C3=9Fenhofer (geb. Eberlei)</div><div>Registergericht: Amtsgericht Bonn, =
HRB 22127</div></div></div></div></div>

--000000000000847b65062d63016f--