Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126283
Date: Tue, 4 Feb 2025 11:10:51 +0000 (GMT)
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
cc: Volker Dusch <volker@tideways-gmbh.com>, 
    php internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] RFC: Marking return values as important
 (#[\NoDiscard])
In-Reply-To: <a995ac24905030e168e7f6006b996cd5@bastelstu.be>
Message-ID: <7175feba-85ea-ce60-f89c-36ea1a7ed574@php.net>
References: <a995ac24905030e168e7f6006b996cd5@bastelstu.be>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1010792254-1738667451=:27891"
From: derick@php.net (Derick Rethans)

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1010792254-1738667451=:27891
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Wed, 29 Jan 2025, Tim D=C3=BCsterhus wrote:

> Hi
>=20
> Volker and I would like to start discussion on our RFC to allow "Marking
> return values as important (#[\NoDiscard])".
>=20
> Please find the following resources for your reference:
>=20
> - RFC: https://wiki.php.net/rfc/marking_return_value_as_important
> - Implementation: https://github.com/php/php-src/pull/17599

Looks reasonable to me.

What's the reason why this emits a warning though, instead of throwing=20
an Exception? I'm sure you thought of it, but it would be nice to have=20
that consideration mentioned in the RFC.

cheers,
Derick
--8323329-1010792254-1738667451=:27891--