Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126231
Precedence: bulk
MIME-Version: 1.0
References: <CA+XhMqzoMyB9Qh5UffqH+u8FCN6xSoaD=WzaSgAe2gJZu3D3PQ@mail.gmail.com>
 <CAEKnhAGOrzbXF+Q9GhQ50cBODmVYe4CUHCojmK4tHQkP9eH4gA@mail.gmail.com>
In-Reply-To: <CAEKnhAGOrzbXF+Q9GhQ50cBODmVYe4CUHCojmK4tHQkP9eH4gA@mail.gmail.com>
Date: Wed, 29 Jan 2025 12:27:12 +0000
Message-ID: <CA+XhMqw1MS3+Romc8WwzCj6eVekrJM=eqT5Kf3MuPp+hxDTxsw@mail.gmail.com>
Subject: Re: [PHP-DEV] ext/sockets: socket_getpeername/socket_getsockname BC
To: Jakub Zelenka <bukka@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: devnexen@gmail.com (David CARLIER)

Ok fair enough, will revert it.

Cheers.

On Wed, 29 Jan 2025 at 12:04, Jakub Zelenka <bukka@php.net> wrote:
>
>
>
> On Wed, Jan 29, 2025 at 4:22=E2=80=AFAM David CARLIER <devnexen@gmail.com=
> wrote:
>>
>> Hi,
>>
>> Working on this PR #17440, I wanted to ask if the BC from these two call=
s
>> were ok because :
>>
>> Before
>>
>> function socket_getsockname(Socket $socket, &$address, &$port =3D null):=
 bool {}
>>
>> After
>>
>> function socket_getsockname(Socket $socket, &$address, ?int &$objint =3D=
 null): bool {}
>>
>> As it is no longer only used for port but also for. interface address in=
dex in the case of AF_PACKET.
>>
>
> Please no BC break. It's really not worth it.
>
> Cheers
>
> Jakub