Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:126230 X-Original-To: internals@lists.php.net Delivered-To: internals@lists.php.net Received: from php-smtp4.php.net (php-smtp4.php.net [45.112.84.5]) by qa.php.net (Postfix) with ESMTPS id E4DB21A00BC for ; Wed, 29 Jan 2025 12:04:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=php.net; s=mail; t=1738152125; bh=Sfr6QKZVJP7MmS9IH5aThff3cMNxZ7mlI7zo5gTEwEo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bw5jH+SHGccGFUjbOgSCUyrOp2a5igKj0G1ybDF/jTNy/J1VkDuCjU0c+VOoOTblg 3FlBwOY49m6gHSTnf7ftdmwao1lO2Vo6ayGuX5QuL8RqVRa22gfJpo6x7gM0rBh9Bz wqo3cqNZOGoYgaES7I8De24LdjJgJL3ZtUPSQbbKcvboNFtiIrXTkZ36nwGn17T3G7 VrodHzu3NOpSXzKG0xox7bXWO90WArA5kz7rYC309zDXknjObutp2ja9p+ATTj9U04 pTo/zprTYUQDhnd8V5IwUoNWyD8cfjVDB1pe+/07wUo7AKv38jzEwzLEuhudInvXbf rnKj8yjrBOXhA== Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id D64E71801E0 for ; Wed, 29 Jan 2025 12:02:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on php-smtp4.php.net X-Spam-Level: * X-Spam-Status: No, score=2.0 required=5.0 tests=BAYES_50,DMARC_NONE, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=4.0.0 X-Spam-Virus: No X-Envelope-From: Received: from mail-oo1-f45.google.com (mail-oo1-f45.google.com [209.85.161.45]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Wed, 29 Jan 2025 12:02:04 +0000 (UTC) Received: by mail-oo1-f45.google.com with SMTP id 006d021491bc7-5fa2a2bdde9so1543575eaf.0 for ; Wed, 29 Jan 2025 04:04:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738152292; x=1738757092; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Sfr6QKZVJP7MmS9IH5aThff3cMNxZ7mlI7zo5gTEwEo=; b=jNQ3UddDnSLsR8H55ioVHBj3//l//Du7KreqKaj8rq2F0+ock7l5dVFBMD9u8G32GB PK0QqrXOAHtLM5CjrD67UYp6+drY1tlp3lXDJpnymCnto10nHLj3DVf9tUHxSlR0iE1z F4/cguZ8dtXJzoniYLkiUuLz2/fsABYNHsCYvUSHVPIJh68gXAIGPkGuS0mulTMv9fw4 ttPSMI+d6bdPY80rHcTU3FVqo4O1bI3CzID6pCupktUO8AGdZF9owTsyqtzA9m7xMlZU ndAnP5/VdzT1hmvufSeGvRnYKGkezuMNSthW6oMtitT/yq9UTm9kcIMpu6rSqrBx1036 t7Dg== X-Gm-Message-State: AOJu0Ywn5QRX05OLcb0ttjsCw1rCO+94jVMLCi4QP3+zhnVP5e/zBs9y s5KZk9xSGLRiqnbMlO1BlmmLqPB8tbQK197t9yXyJtzhNugEaKmme4xxvmy7SQYmd8G6FO3kn24 9mHvp2189XrMFjCbEOhMasFM5Ef4= X-Gm-Gg: ASbGncsIzW3aEAEUeIqGntzkLYb8kSlsRhLJ+TtE6lUBG6NbO7JivcMAEJxr5u0ykmw +wEhAoStXQqY2YXJYdyRi6jHvoL6YiPut4lxqNpeIzJ6l7FdvGXAfWaT0unrwysospMBoYMJP X-Google-Smtp-Source: AGHT+IGmzQ0ri2rL3u0HxLMpWCEmaXDuQylGCxz3dI1HcwlbdE+h9t2elOPBn6BHgU0CaaW+mXyNvCviZfzs/DqJhW8= X-Received: by 2002:a05:6871:3a83:b0:29e:67cd:1a8f with SMTP id 586e51a60fabf-2b32f2ed3d8mr1254393fac.37.1738152291774; Wed, 29 Jan 2025 04:04:51 -0800 (PST) Precedence: bulk list-help: list-post: List-Id: internals.lists.php.net x-ms-reactions: disallow MIME-Version: 1.0 References: In-Reply-To: Date: Wed, 29 Jan 2025 13:04:40 +0100 X-Gm-Features: AWEUYZmi0VGdR-Nq_xPH1JV6y2xHMy4_bDSbz8hPTESmX8Q6qRlrFsyXaFGz7jg Message-ID: Subject: Re: [PHP-DEV] ext/sockets: socket_getpeername/socket_getsockname BC To: David CARLIER Cc: PHP internals Content-Type: multipart/alternative; boundary="000000000000eab8c2062cd71d9e" From: bukka@php.net (Jakub Zelenka) --000000000000eab8c2062cd71d9e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jan 29, 2025 at 4:22=E2=80=AFAM David CARLIER = wrote: > Hi, > > Working on this PR #17440 , I > wanted to ask if the BC from these two calls > were ok because : > > Before > > function socket_getsockname(Socket $socket, &$address, *&$port =3D null*)= : > bool {} > > After > > function socket_getsockname(Socket $socket, &$address, *?int &$objint =3D > null*): bool {} > > As it is no longer only used for port but also for. interface address > index in the case of AF_PACKET. > > Please no BC break. It's really not worth it. Cheers Jakub --000000000000eab8c2062cd71d9e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Jan 29,= 2025 at 4:22=E2=80=AFAM David CARLIER <devnexen@gmail.com> wrote:
Hi,

Working on this PR=C2= =A0= #17440, I wanted to ask if the BC from these two calls
were ok beca= use :

Before

function socket_getsockname(Socket $socket, &$address, &= $por= t =3D null): bool {}

After
=

functio= n socket_getsockname(Socket $socket, &$address, ?int &$objint =3D n= ull): b= ool {}

As it is no longer only used for port but also for. interface address ind= ex in the case of AF_PACKET.


Please no BC break. It's really not worth it= .

Cheers

Jakub=C2=A0
--000000000000eab8c2062cd71d9e--