Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126229
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\))
Subject: Re: [PHP-DEV] ext/sockets: socket_getpeername/socket_getsockname BC
Date: Wed, 29 Jan 2025 11:01:11 +0100
References: <CA+XhMqzoMyB9Qh5UffqH+u8FCN6xSoaD=WzaSgAe2gJZu3D3PQ@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
In-Reply-To: <CA+XhMqzoMyB9Qh5UffqH+u8FCN6xSoaD=WzaSgAe2gJZu3D3PQ@mail.gmail.com>
Message-ID: <BDE4A8BA-3E28-4294-A48F-F1B67EEBAA77@cschneid.com>
From: cschneid@cschneid.com (Christian Schneider)

Am 29.01.2025 um 04:20 schrieb David CARLIER <devnexen@gmail.com>:
> Working on this PR #17440, I wanted to ask if the BC from these two =
calls were ok because :
>=20
> Before
> 	function socket_getsockname(Socket $socket, &$address, &$port =3D =
null): bool {}
>=20
> After
> 	function socket_getsockname(Socket $socket, &$address, ?int =
&$objint =3D null): bool {}
>=20
> As it is no longer only used for port but also for. interface address =
index in the case of AF_PACKET.

Personally I would leave it at $port for two reasons:
1) BC break without a big benefit
2) I don't think $objint is a meaningful name

While it might not be 100% accurate for AF_PACKET I think the concept of =
a port is well enough established in the networking word and the more =
common usage (AF_INET*) makes me think this inconsistency with AF_PACKET =
is not a real problem.

Regards,
- Chris