Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:126228 X-Original-To: internals@lists.php.net Delivered-To: internals@lists.php.net Received: from php-smtp4.php.net (php-smtp4.php.net [45.112.84.5]) by qa.php.net (Postfix) with ESMTPS id B18A11A00BC for ; Wed, 29 Jan 2025 03:20:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=php.net; s=mail; t=1738120663; bh=MlGqXEGEebrIGGMdIYsCNBUvBWzjpBAabtTD255PkWY=; h=From:Date:Subject:To:From; b=jXezXhYg6ZhHvS7kYVyBb3z6E3eO1pjSAM5SEVNZzwl5FHZQ75YWPg6KrsZ/pU8C6 GlI1LFX3D3LtzF8EeV3h4I796lm7hC19A/16jS4xV0U37ADGHTZt9t2D5lzQE2vLQ3 l9ed7reCOK3rEEh5Md6SgBFl2Ig0yiJsYBoVEGNT/lz38qoRWLzaPs8YlCDVYO3cMB Wzb/C1fwORxgulcWJVsK+ohxQcb9pz5YP2f9bSZyv0ek4dXQX26qVT/a4oCuXeaS1C jtnODdnfyemapiNtNnMp9DXqMFZDpfUnFjj52+KuduoiPRtREKQj0aiqR6VOB8ojEV n/JynP/zLM/fA== Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 7DB50180039 for ; Wed, 29 Jan 2025 03:17:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,FREEMAIL_FROM, HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=4.0.0 X-Spam-Virus: No X-Envelope-From: Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Wed, 29 Jan 2025 03:17:39 +0000 (UTC) Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-3eb9bbcc936so3903240b6e.0 for ; Tue, 28 Jan 2025 19:20:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738120826; x=1738725626; darn=lists.php.net; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=MlGqXEGEebrIGGMdIYsCNBUvBWzjpBAabtTD255PkWY=; b=Su4xngyTNkuW9uBAKM3NMXwWVb8HYIuEomNLg3E0mPZjZ4AoExKhIOoha8Orbstv4k jYw2zroJ6NsacRAi31w4gMM/gQElYVRddtLJkSExSXIruqfDEBNXkYMbm244l2d2VkTK XM0qcH0NTeFJw1uTkV44IbCjoCrVuag1ptbIJrsQLGr9MnxuyRNGx/K7ZC26tlOo4399 QPswk4bWetODnNK9o/RJtRhs+O8uLVD542fZHTApf63T7Vl4exRcGe77pqmrTZK2CXeM ujK19uRoIcKXj4dzQXUiqJWc8LwrvtcVz9EiF2xNzeBPcj9kqvEfKsXBapJW59daT/SQ gHMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738120826; x=1738725626; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MlGqXEGEebrIGGMdIYsCNBUvBWzjpBAabtTD255PkWY=; b=B3BTn7yrs03Xt2T3O0X7xdt9OC7x0Np6Y3dK4FigVtgEQtMOFQrHFX3yQjamsulrQP x298xeSXRqo/ZRCuXPVzFrd2O6h5zMNYC1cLRAYZAwTnnOL8gdukQJa0tJWikx4KuZ8p nQj+tbCFcyA/xzT5e+OvWNLTHjlzBAUYWtZ0c+rRKliqsBYsNDflVB65GtKsz4uOvQFU OTn0S9RUio1Z9hhctE46HLuHwL3vKlsKrNmskIqioWl1fEWMoC1iINPJSFP/3vsIxAw7 nhhK9C+uQp4hztATAYzel0tT00tOcVAOBq0bVWrHgvl1bzgz0ERWPYSHmvunkgrXOnLV gYUg== X-Gm-Message-State: AOJu0YyQGTJiu4pZ7ZE390azrsbyQxy63jP5ODld0TTFL3ceWDmTE/1d tlacFF3dcDiTyp8nhEwvriiVgDWl5weOUEwzqrdIro/yLLYX1g3r/vdEgyTqfc35pJXWU1LNect pvF0+aI2Z6q2ddSdiIqI14f3RMlDwAI9Fc1Q= X-Gm-Gg: ASbGncvFFCZGofhB5ZARn3gQlLwi+v1bI/wcM/E8KeNDxXV7DFiW0rAyr6rXZIuxwQ6 3R0lN7+iPYGQi10jTf5tgxUE+SzlilUEs562Fj0tsR1vnMpp2UUkLQ7oP0Y5L4j3EUnMRKn8= X-Google-Smtp-Source: AGHT+IEQmrwEUrirsoQakbJ31KtrLlwjk5ynA+hZiNaHGV3FwOe9ADaBCt6VWiQDWgPVyVJ8GRrtB+/nPRh1sAz5k44= X-Received: by 2002:a05:6808:2104:b0:3eb:8eb0:8166 with SMTP id 5614622812f47-3f323b6f2a9mr774417b6e.36.1738120826501; Tue, 28 Jan 2025 19:20:26 -0800 (PST) Precedence: bulk list-help: list-post: List-Id: internals.lists.php.net x-ms-reactions: disallow MIME-Version: 1.0 Date: Wed, 29 Jan 2025 03:20:15 +0000 X-Gm-Features: AWEUYZnSXyEvLbgLaOx07FoIAElpeqLnP4uhiABDp0fxNCy3JIk2HlbkonRPsXA Message-ID: Subject: [PHP-DEV] ext/sockets: socket_getpeername/socket_getsockname BC To: PHP internals Content-Type: multipart/alternative; boundary="00000000000070c317062ccfcaa8" From: devnexen@gmail.com (David CARLIER) --00000000000070c317062ccfcaa8 Content-Type: text/plain; charset="UTF-8" Hi, Working on this PR #17440 , I wanted to ask if the BC from these two calls were ok because : Before function socket_getsockname(Socket $socket, &$address, *&$port = null*): bool {} After function socket_getsockname(Socket $socket, &$address, *?int &$objint = null*): bool {} As it is no longer only used for port but also for. interface address index in the case of AF_PACKET. Thanks. Regards. --00000000000070c317062ccfcaa8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

Working on this PR=C2=A0#17440, I wanted to ask if the BC from t= hese two calls
were ok because :

Before
<= div>
function socket_getsockname(Socket = $socket<= /span>, &$address, &$port =3D null): bool {}

= After

funct= ion socke= t_getsockname(Socket $socket, &$address= , ?<= span class=3D"gmail-pl-smi gmail-x" style=3D"box-sizing:border-box;color:rg= b(31,35,40);font-family:ui-monospace,SFMono-Regular,"SF Mono",Men= lo,Consolas,"Liberation Mono",monospace;font-size:12px">int &$objint =3D null): = bool {}

As i= t is no longer only used for port but also for. interface address index in = the case of AF_PACKET.


Thanks.

Regards. --00000000000070c317062ccfcaa8--