Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:126223
Precedence: bulk
MIME-Version: 1.0
Date: Fri, 24 Jan 2025 23:31:28 +0100
To: Hans Henrik Bergan <hans@loltek.net>
Cc: PHP Internals List <internals@lists.php.net>
Subject: Re: [PHP-DEV] BLAKE3 hash redux
In-Reply-To: <CAK7R4azXE=XT4yuaEjMKH1jRmHSaAQ-ocDL17Q_Ow+9TijoC2A@mail.gmail.com>
References: <CAK7R4awkLmRVZ_nGJfae6P-rgLf2o4WYjv+S4iCLZC5q-YEF3g@mail.gmail.com>
 <995b9de75fc45af9b4afc327977b3ed8@bastelstu.be>
 <CAK7R4azXE=XT4yuaEjMKH1jRmHSaAQ-ocDL17Q_Ow+9TijoC2A@mail.gmail.com>
Message-ID: <271bafc7eaf256bebf9060e0713c6385@bastelstu.be>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

Am 2025-01-24 22:37, schrieb Hans Henrik Bergan:
> BLAKE3 keeping up with dedicated SHA CPU instructions (i.e SHA-NI) is
> impressive.

I would assume that that's the AVX2 implementation (my CPU can't 
AVX512), which makes it less impressive.

> ARM is getting more and more common, and I don't think ARM has SHA
> instructions (yet?) tho.

The ARM architecture has them, but PHP does not yet make use of them. 
This is mainly due to me being unable to test the integration, due to 
lacking an appropriate system. libcperciva where I've taken the SHA-NI 
implementation from also includes the ARM implementation and I checked 
with the author regarding the necessary attribution as part of the x64 
SHA-NI PR: 
https://github.com/php/php-src/pull/15152#issuecomment-2256476578.

>> As for the RFC itself: I suggest to already add the (closed) voting
>> doodle to the proposed voting choices section. The way the section is
>> currently worded doesn't make sense, because it implies two distinct
>> votes.
> 
> like this I guess:
> 

Yes. Ideally mention above that it requires a "2/3 majority" (as with 
any other RFC, but good to spell it out explicitly).

Best regards
Tim Düsterhus